[FLINK-9888] Remove unsafe defaults from release scripts

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.4.0, 1.5.0, 1.6.0
• Fix Version/s: 1.4.3, 1.5.2, 1.6.0
• Component/s: Release System
• Labels: pull-request-available
• Assignee: Chesnay Schepler
• Reporter: Chesnay Schepler
• Created: 18/Jul/18 11:35
• Updated: 23/Jul/18 18:59
• Resolved: 23/Jul/18 18:59

Description

Several variables in the release scripts have unsafe defaults, like these from create_release_branch.sh:

OLD_VERSION=${OLD_VERSION:-1.2-SNAPSHOT}
NEW_VERSION=${NEW_VERSION:-1.3-SNAPSHOT}

We should not allow the script to run successfully without these being explicitly set.

Issue Links

• links to: GitHub Pull Request #6362