[FLINK-9844] PackagedProgram does not close URLClassLoader

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.4.2, 1.5.1, 1.6.0
• Fix Version/s: 1.11.4, 1.12.2, 1.13.0
• Component/s: Command Line Client, Runtime / REST
• Labels: pull-request-available
• Assignee: Chesnay Schepler
• Reporter: Chesnay Schepler
• Created: 13/Jul/18 09:29
• Updated: 28/May/21 08:17
• Resolved: 03/Feb/21 10:12

Description

The PackagedProgram class creates a user-code classloader to execute the programs main method.
This classloader is a URLClassLoader (except in the case of some tests), which contains opened JarFiles for all accessed jars.

The URLClassLoader class implements Closeable for the purpose of cleaning up closeable resources, however we never actually call this method. The PackagedProgram only works against the ClassLoader class, which doesn't implement Closeable.

As a result, deleting a jar after submitting it with the JarRunHandler currently fails on Windows, since the jar is still in use.

As far as i can tell after the JobGraph has been compiled this classloader is no longer necessary and should be closed. (This assumes that a given PackagedProgram is only used once to create a JobGraph}}, otherwise we'd needa dedicate close method)

Issue Links

• links to: GitHub Pull Request #14810