Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-9787

Change ExecutionConfig#getGlobalJobParameters to return an instance of GlobalJobParameters instead of null if no custom globalJobParameters are set yet

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • The `ExecutionConfig#setGlobalJobParameters` only accepts non null argument values.

    Description

      Currently when accessing ExecutionConfig#getGlobalJobParameters this will return `null` if no globalJobParameters are set. This can easily lead to NullPointerExceptions when used with getGlobalJobParameters.toMap()

      An easy improvement for this would be to just return a new instance of GlobalJobParameters if none is set with the empty map as the parameters

      This would be a breaking change since we expose this via RuntimeContext#getExecutionConfig

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            tianchen92 Ji Liu
            florianschmidt Florian Schmidt
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 20m
                20m

                Slack

                  Issue deployment