[FLINK-9755] Exceptions in RemoteInputChannel#notifyBufferAvailable() are not propagated to the responsible thread

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 1.5.0
• Fix Version/s: 1.5.2, 1.6.0
• Component/s: Runtime / Network
• Labels: pull-request-available
• Assignee: Nico Kruber
• Reporter: Nico Kruber
• Created: 04/Jul/18 22:35
• Updated: 19/Jul/18 19:31
• Resolved: 19/Jul/18 19:31

Description

The credit-based flow control implementation of RemoteInputChannel#notifyBufferAvailable() does not forward errors (like the IllegalStateException) to the thread that is being notified. The calling code at LocalBufferPool#recycle, however, relies on the callback forwarding errors and completely ignores any failures.

Therefore, we could end up with a program waiting forever for the callback and not even a failure message in the logs.

Issue Links

• relates to: FLINK-9756 Exceptions in BufferListener#notifyBufferAvailable do not trigger further listeners in LocalBufferPool#recycle()
• links to: GitHub Pull Request #6272