[FLINK-9528] Incorrect results: Filter does not treat Upsert messages correctly.

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 1.3.3, 1.4.2, 1.5.0
• Fix Version/s: 1.11.0
• Component/s: Table SQL / Planner
• Assignee: Unassigned
• Reporter: Fabian Hueske
• Created: 05/Jun/18 09:26
• Updated: 17/May/20 07:52
• Resolved: 16/May/20 14:26

Description

Currently, Filters (i.e., Calcs with predicates) do not distinguish between retraction and upsert mode. A Calc looks at record (regardless of its update semantics) and either discard it (predicate evaluates to false) or pass it on (predicate evaluates to true).

This works fine for messages with retraction semantics but is not correct for upsert messages.

The following test case (can be pasted into TableSinkITCase) shows the problem:

  @Test
  def testUpsertsWithFilter(): Unit = {
    val env = StreamExecutionEnvironment.getExecutionEnvironment
    env.getConfig.enableObjectReuse()
    env.setStreamTimeCharacteristic(TimeCharacteristic.EventTime)
    val tEnv = TableEnvironment.getTableEnvironment(env)

    val t = StreamTestData.get3TupleDataStream(env)
      .assignAscendingTimestamps(_._1.toLong)
      .toTable(tEnv, 'id, 'num, 'text)

    t.select('text.charLength() as 'len)
      .groupBy('len)
      .select('len, 'len.count as 'cnt)
      // .where('cnt < 7)
      .writeToSink(new TestUpsertSink(Array("len"), false))

    env.execute()
    val results = RowCollector.getAndClearValues

    val retracted = RowCollector.upsertResults(results, Array(0)).sorted
    val expectedWithoutFilter = List(
      "2,1", "5,1", "9,9", "10,7", "11,1", "14,1", "25,1").sorted
    val expectedWithFilter = List(
    "2,1", "5,1", "11,1", "14,1", "25,1").sorted

    assertEquals(expectedWithoutFilter, retracted)
    // assertEquals(expectedWithFilter, retracted)
  }

When we add a filter on the aggregation result, we would expect that all rows that do not fulfill the condition are removed from the result. However, the filter only removes the upsert message such that the previous version remains in the result.

One solution could be to make a filter aware of the update semantics (retract or upsert) and convert the upsert message into a delete message if the predicate evaluates to false.

Issue Links

• is fixed by: FLINK-16887 Refactor retraction rules to support inferring ChangelogMode