[FLINK-9500] FileUploadHandler does not handle EmptyLastHttpContent

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.5.0, 1.6.0
• Fix Version/s: 1.5.1, 1.6.0
• Component/s: Command Line Client, Runtime / REST
• Assignee: Chesnay Schepler
• Reporter: Chesnay Schepler
• Created: 01/Jun/18 22:33
• Updated: 16/Sep/22 13:04
• Resolved: 22/Jun/18 10:49

Description

The FileUploadHandler does not properly handle EmptyLastHttpContent messages. When passing these to a decoder an exception is thrown.

We should either catch the exception or just don't pass such a message in the first place.

018-06-01 16:05:46,514 WARN org.apache.flink.runtime.dispatcher.DispatcherRestEndpoint - Unhandled exception org.apache.flink.shaded.netty4.io.netty.handler.codec.http.multipart.HttpPostRequestDecoder$EndOfDataDecoderException at org.apache.flink.shaded.netty4.io.netty.handler.codec.http.multipart.HttpPostMultipartRequestDecoder.hasNext(HttpPostMultipartRequestDecoder.java:366) at org.apache.flink.shaded.netty4.io.netty.handler.codec.http.multipart.HttpPostRequestDecoder.hasNext(HttpPostRequestDecoder.java:241) at org.apache.flink.runtime.rest.FileUploadHandler.channelRead0(FileUploadHandler.java:92) at org.apache.flink.runtime.rest.FileUploadHandler.channelRead0(FileUploadHandler.java:51) at org.apache.flink.shaded.netty4.io.netty.channel.SimpleChannelInboundHandler.channelRead(SimpleChannelInboundHandler.java:105) at org.apache.flink.shaded.netty4.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(A

Issue Links

• is related to: FLINK-29326 EndOfDataDecoderException observed when uploading a jar