[FLINK-8075] Lack of synchronization calling clone() in Configuration ctor

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Not A Problem
• Assignee: Unassigned
• Reporter: Ted Yu
• Created: 14/Nov/17 22:37
• Updated: 15/Nov/17 08:50
• Resolved: 15/Nov/17 08:50

Description

In flink-filesystems/flink-s3-fs-presto/src/main/java/org/apache/hadoop/conf/Configuration.java , at line 703:

  public Configuration(Configuration other) {
    this.resources = (ArrayList<Resource>) other.resources.clone();
    synchronized(other) {
      if (other.properties != null) {
        this.properties = (Properties)other.properties.clone();
      }

The first clone() call is without synchronization and without null check.