[FLINK-7736] Fix some of the alerts raised by lgtm.com

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.5.0
• Assignee: Malcolm Taylor
• Reporter: Malcolm Taylor
• Created: 28/Sep/17 18:16
• Updated: 02/Oct/19 17:49
• Resolved: 30/Jan/18 13:10

Description

lgtm.com has identified a number of issues giving scope for improvement in the code: https://lgtm.com/projects/g/apache/flink/alerts/?mode=list
This issue is to address some of the simpler ones. Some of these are quite clear bugs such as off-by-one errors. Others are areas where the code might be made clearer, such as use of a variable name which shadows another variable.

Issue Links

• links to: GitHub Pull Request #4784