[FLINK-7309] NullPointerException in CodeGenUtils.timePointToInternalCode() generated code

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 1.3.1
• Fix Version/s: 1.3.4, 1.4.0
• Component/s: Runtime / Task, Table SQL / API
• Assignee: Unassigned
• Reporter: Liangliang Chen
• Created: 31/Jul/17 13:16
• Updated: 12/Mar/18 15:29
• Resolved: 12/Mar/18 15:29

Description

The code generated by CodeGenUtils.timePointToInternalCode() will cause a NullPointerException when SQL table field type is `TIMESTAMP` and the field value is `null`.

Example for reproduce:

object StreamSQLExample {
  def main(args: Array[String]): Unit = {
    val env = StreamExecutionEnvironment.getExecutionEnvironment
    val tEnv = TableEnvironment.getTableEnvironment(env)

    // null field value
    val orderA: DataStream[Order] = env.fromCollection(Seq(
      Order(null, "beer", 3)))
      
    tEnv.registerDataStream("OrderA", orderA, 'ts, 'product, 'amount)
    val result = tEnv.sql("SELECT * FROM OrderA")
    result.toAppendStream[Order].print()
    
    env.execute()
  }

  case class Order(ts: Timestamp, product: String, amount: Int)
}

In the above example, timePointToInternalCode() will generated some statements like this:

...
          long result$1 = org.apache.calcite.runtime.SqlFunctions.toLong((java.sql.Timestamp) in1.ts());
          boolean isNull$2 = (java.sql.Timestamp) in1.ts() == null;
...

so, the NPE will happen when in1.ts() is null.

Issue Links

• links to: GitHub Pull Request #4479