Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-7233

TaskManagerHeapSizeCalculationJavaBashTest failed on Travis

    Details

    • Release Note:
      Hide
      Fixed in
        - 1.3.2 via 129a82fbadaddf9befef86cc20797d698ee92e96
        - 1.4.0 via 3a503cd30b436b75a6b93a7a216d7b6d4de20a55
      Show
      Fixed in   - 1.3.2 via 129a82fbadaddf9befef86cc20797d698ee92e96   - 1.4.0 via 3a503cd30b436b75a6b93a7a216d7b6d4de20a55

      Description

      Running org.apache.flink.dist.TaskManagerHeapSizeCalculationJavaBashTest
      Tests run: 2, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 2.926 sec <<< FAILURE! - in org.apache.flink.dist.TaskManagerHeapSizeCalculationJavaBashTest
      compareNetworkBufShellScriptWithJava(org.apache.flink.dist.TaskManagerHeapSizeCalculationJavaBashTest)  Time elapsed: 1.443 sec  <<< ERROR!
      org.apache.flink.configuration.IllegalConfigurationException: Invalid configuration value for taskmanager.network.memory.min : -2147479274 - Minimum memory for network buffers must allow at least one network buffer with respect to the memory segment size
      	at org.apache.flink.runtime.taskexecutor.TaskManagerServicesConfiguration.checkConfigParameter(TaskManagerServicesConfiguration.java:459)
      	at org.apache.flink.runtime.taskexecutor.TaskManagerServicesConfiguration.checkNetworkBufferConfig(TaskManagerServicesConfiguration.java:397)
      	at org.apache.flink.runtime.taskexecutor.TaskManagerServices.calculateNetworkBufferMemory(TaskManagerServices.java:427)
      	at org.apache.flink.dist.TaskManagerHeapSizeCalculationJavaBashTest.getRandomConfig(TaskManagerHeapSizeCalculationJavaBashTest.java:198)
      	at org.apache.flink.dist.TaskManagerHeapSizeCalculationJavaBashTest.compareNetworkBufShellScriptWithJava(TaskManagerHeapSizeCalculationJavaBashTest.java:95)
      

        Issue Links

          Activity

          Hide
          Zentol Chesnay Schepler added a comment -

          Nico Kruber you you want to look into this?

          Show
          Zentol Chesnay Schepler added a comment - Nico Kruber you you want to look into this?
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user NicoK opened a pull request:

          https://github.com/apache/flink/pull/4378

          FLINK-7233[tests] fix instable TaskManagerHeapSizeCalculationJavaBashTest

          This fixes `getRandomConfig()` being prone to integer overflows and creating
          invalid configuration values.

          • [X] General
          • The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
          • The pull request addresses only one issue
          • Each commit in the PR has a meaningful commit message (including the JIRA id)
          • [X] Tests & Build
          • Functionality added by the pull request is covered by tests
          • `mvn clean verify` has been executed successfully locally or a Travis build has passed

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/NicoK/flink flink-7233

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/4378.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #4378


          commit d0a5e3116b4aefc10603a43d077583e2f7cd99de
          Author: Nico Kruber <nico@data-artisans.com>
          Date: 2017-07-20T09:44:08Z

          FLINK-7233[tests] fix instable TaskManagerHeapSizeCalculationJavaBashTest

          This fixes getRandomConfig() being prone to integer overflows and creating
          invalid configuration values.


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user NicoK opened a pull request: https://github.com/apache/flink/pull/4378 FLINK-7233 [tests] fix instable TaskManagerHeapSizeCalculationJavaBashTest This fixes `getRandomConfig()` being prone to integer overflows and creating invalid configuration values. [X] General The pull request references the related JIRA issue (" [FLINK-XXX] Jira title text") The pull request addresses only one issue Each commit in the PR has a meaningful commit message (including the JIRA id) [X] Tests & Build Functionality added by the pull request is covered by tests `mvn clean verify` has been executed successfully locally or a Travis build has passed You can merge this pull request into a Git repository by running: $ git pull https://github.com/NicoK/flink flink-7233 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/4378.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4378 commit d0a5e3116b4aefc10603a43d077583e2f7cd99de Author: Nico Kruber <nico@data-artisans.com> Date: 2017-07-20T09:44:08Z FLINK-7233 [tests] fix instable TaskManagerHeapSizeCalculationJavaBashTest This fixes getRandomConfig() being prone to integer overflows and creating invalid configuration values.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user StephanEwen commented on the issue:

          https://github.com/apache/flink/pull/4378

          Good fix!

          Merging to `master` and `release-1.3`...

          Show
          githubbot ASF GitHub Bot added a comment - Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/4378 Good fix! Merging to `master` and `release-1.3`...
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/4378

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4378

            People

            • Assignee:
              NicoK Nico Kruber
              Reporter:
              Zentol Chesnay Schepler
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development