Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-7178

Datadog Metric Reporter Jar is Lacking Dependencies

        Details

        • Type: Bug
        • Status: Closed
        • Priority: Critical
        • Resolution: Fixed
        • Affects Version/s: 1.3.1, 1.4.0
        • Fix Version/s: 1.4.0, 1.3.2
        • Component/s: Metrics
        • Labels:
          None
        • Release Note:
          Users that specified the {{shaded}} classifier in the dependency for the datatog/prometheus reporter must remove the classifier when switching to 1.3.2 / 1.4.0 .

          Description

          The Datadog metric reporter has dependencies on com.squareup.okhttp3 and com.squareup.okio. It appears there was an attempt to Maven Shade plug-in to move these classes to org.apache.flink.shaded.okhttp3 and org.apache.flink.shaded.okio during packaging. Alas, the shaded classes are not included in the flink-metrics-datadog-1.3.1.jar released to Maven Central. Using the Jar results in an error when the Jobmanager or Taskmanager starts up because of the missing dependencies.

            Issue Links

            links to

            Web Link GitHub Pull Request #4326

            Web Link GitHub Pull Request #4327

              Activity

              Descending order - Click to sort in ascending order
              Hide
              Permalink
              Zentol Chesnay Schepler added a comment -

              1.4: 67fb2f3ab1eafddc1bf67e4046225cf018ed5369

              Show
              Zentol Chesnay Schepler added a comment - 1.4: 67fb2f3ab1eafddc1bf67e4046225cf018ed5369
              Hide
              Permalink
              githubbot ASF GitHub Bot added a comment -

              Github user asfgit closed the pull request at:

              https://github.com/apache/flink/pull/4326

              Show
              githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4326
              Hide
              Permalink
              githubbot ASF GitHub Bot added a comment -

              GitHub user zentol reopened a pull request:

              https://github.com/apache/flink/pull/4326

              FLINK-7178 [metrics] Do not create separate shaded jars

              You can merge this pull request into a Git repository by running:

              $ git pull https://github.com/zentol/flink 7178

              Alternatively you can review and apply these changes as the patch at:

              https://github.com/apache/flink/pull/4326.patch

              To close this pull request, make a commit to your master/trunk branch
              with (at least) the following in the commit message:

              This closes #4326

              commit 4b88f85d0ab0bdd65fc49fa7c27ba61a3309d2b4
              Author: zentol <chesnay@apache.org>
              Date: 2017-07-13T20:06:56Z

              FLINK-7178 [metrics] Do not create separate shaded jars

              commit 7f3b6e167089d616f190f380e332ea27f3f98efb
              Author: zentol <chesnay@apache.org>
              Date: 2017-07-17T14:08:54Z

              fix assemblies

              Show
              githubbot ASF GitHub Bot added a comment - GitHub user zentol reopened a pull request: https://github.com/apache/flink/pull/4326 FLINK-7178 [metrics] Do not create separate shaded jars You can merge this pull request into a Git repository by running: $ git pull https://github.com/zentol/flink 7178 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/4326.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4326 commit 4b88f85d0ab0bdd65fc49fa7c27ba61a3309d2b4 Author: zentol <chesnay@apache.org> Date: 2017-07-13T20:06:56Z FLINK-7178 [metrics] Do not create separate shaded jars commit 7f3b6e167089d616f190f380e332ea27f3f98efb Author: zentol <chesnay@apache.org> Date: 2017-07-17T14:08:54Z fix assemblies
              Hide
              Permalink
              githubbot ASF GitHub Bot added a comment -

              Github user zentol closed the pull request at:

              https://github.com/apache/flink/pull/4327

              Show
              githubbot ASF GitHub Bot added a comment - Github user zentol closed the pull request at: https://github.com/apache/flink/pull/4327
              Hide
              Permalink
              githubbot ASF GitHub Bot added a comment -

              Github user zentol closed the pull request at:

              https://github.com/apache/flink/pull/4326

              Show
              githubbot ASF GitHub Bot added a comment - Github user zentol closed the pull request at: https://github.com/apache/flink/pull/4326
              Hide
              Permalink
              Zentol Chesnay Schepler added a comment -

              1.3: 3c0f38369000ed4a1a5f16140e7f88770a10057d

              Show
              Zentol Chesnay Schepler added a comment - 1.3: 3c0f38369000ed4a1a5f16140e7f88770a10057d
              Hide
              Permalink
              githubbot ASF GitHub Bot added a comment -

              Github user zentol commented on the issue:

              https://github.com/apache/flink/pull/4326

              @aljoscha The fix is not quite correct since I didn't update the flink-dist assembly files. Just pushed a fix for that though. I can merge it later today. (once my local travis passed for it)

              Show
              githubbot ASF GitHub Bot added a comment - Github user zentol commented on the issue: https://github.com/apache/flink/pull/4326 @aljoscha The fix is not quite correct since I didn't update the flink-dist assembly files. Just pushed a fix for that though. I can merge it later today. (once my local travis passed for it)
              Hide
              Permalink
              githubbot ASF GitHub Bot added a comment -

              Github user aljoscha commented on the issue:

              https://github.com/apache/flink/pull/4326

              @zentol What's the plan for merging this? (Asking because it's one of the remaining blockers for `1.3.2`)

              Show
              githubbot ASF GitHub Bot added a comment - Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/4326 @zentol What's the plan for merging this? (Asking because it's one of the remaining blockers for `1.3.2`)
              Hide
              Permalink
              githubbot ASF GitHub Bot added a comment -

              Github user StephanEwen commented on the issue:

              https://github.com/apache/flink/pull/4326

              Looks good.

              I would suggest to add a description to the PR (be it only a copy of the JIRA text). Nice support for the reviewers to get context without manually navigating to JIRA to learn about the bug.

              Show
              githubbot ASF GitHub Bot added a comment - Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/4326 Looks good. I would suggest to add a description to the PR (be it only a copy of the JIRA text). Nice support for the reviewers to get context without manually navigating to JIRA to learn about the bug.
              Hide
              Permalink
              Zentol Chesnay Schepler added a comment -

              The maven-shade plugin was not configured correctly and creates a separate shaded jar.

              This shaded jar is also deployed (along with an un-shaded jar); as a workaround for 1.3.1 you can add <classifier>shaded</classifier> to the dependency.

              Show
              Zentol Chesnay Schepler added a comment - The maven-shade plugin was not configured correctly and creates a separate shaded jar. This shaded jar is also deployed (along with an un-shaded jar); as a workaround for 1.3.1 you can add <classifier>shaded</classifier> to the dependency.
              Hide
              Permalink
              githubbot ASF GitHub Bot added a comment -

              GitHub user zentol opened a pull request:

              https://github.com/apache/flink/pull/4327

              FLINK-7178 [metrics] Do not create separate shaded jars

              Backport of #4326 for 1.3.

              You can merge this pull request into a Git repository by running:

              $ git pull https://github.com/zentol/flink 7178_13

              Alternatively you can review and apply these changes as the patch at:

              https://github.com/apache/flink/pull/4327.patch

              To close this pull request, make a commit to your master/trunk branch
              with (at least) the following in the commit message:

              This closes #4327

              commit 5a5cea743c370382f8580aa33b0b62c62c8c62f8
              Author: zentol <chesnay@apache.org>
              Date: 2017-07-13T20:06:56Z

              FLINK-7178 [metrics] Do not create separate shaded jars

              Show
              githubbot ASF GitHub Bot added a comment - GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/4327 FLINK-7178 [metrics] Do not create separate shaded jars Backport of #4326 for 1.3. You can merge this pull request into a Git repository by running: $ git pull https://github.com/zentol/flink 7178_13 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/4327.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4327 commit 5a5cea743c370382f8580aa33b0b62c62c8c62f8 Author: zentol <chesnay@apache.org> Date: 2017-07-13T20:06:56Z FLINK-7178 [metrics] Do not create separate shaded jars
              Hide
              Permalink
              githubbot ASF GitHub Bot added a comment -

              GitHub user zentol opened a pull request:

              https://github.com/apache/flink/pull/4326

              FLINK-7178 [metrics] Do not create separate shaded jars

              You can merge this pull request into a Git repository by running:

              $ git pull https://github.com/zentol/flink 7178

              Alternatively you can review and apply these changes as the patch at:

              https://github.com/apache/flink/pull/4326.patch

              To close this pull request, make a commit to your master/trunk branch
              with (at least) the following in the commit message:

              This closes #4326

              commit 4b88f85d0ab0bdd65fc49fa7c27ba61a3309d2b4
              Author: zentol <chesnay@apache.org>
              Date: 2017-07-13T20:06:56Z

              FLINK-7178 [metrics] Do not create separate shaded jars

              Show
              githubbot ASF GitHub Bot added a comment - GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/4326 FLINK-7178 [metrics] Do not create separate shaded jars You can merge this pull request into a Git repository by running: $ git pull https://github.com/zentol/flink 7178 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/4326.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4326 commit 4b88f85d0ab0bdd65fc49fa7c27ba61a3309d2b4 Author: zentol <chesnay@apache.org> Date: 2017-07-13T20:06:56Z FLINK-7178 [metrics] Do not create separate shaded jars
              Hide
              Permalink
              Zentol Chesnay Schepler added a comment -

              Aljoscha Krettek We got a another blocker here.

              Show
              Zentol Chesnay Schepler added a comment - Aljoscha Krettek We got a another blocker here.

                People

                • Assignee:
                  Zentol Chesnay Schepler
                  Reporter:
                  elevy Elias Levy
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Development