Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.4.0, 1.3.2
    • Fix Version/s: 1.4.0, 1.3.2
    • Component/s: Java API
    • Labels:
      None

      Description

      OperatorTranslation.translateBulkIteration should set the iterationOperator parallelism as in OperatorTranslation.translateDeltaIteration.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user greghogan opened a pull request:

          https://github.com/apache/flink/pull/4283

          FLINK-7132 [java] Fix BulkIteration parallelism

          Copy the parallelism when translating a BulkIteration.

          `translateBulkIteration` now mirrors the setup of the following function `translateDeltaIteration`.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/greghogan/flink 7132_fix_bulkiteration_parallelism

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/4283.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #4283


          commit c4d3d48eb5467630d7f731f1dfa4c9733b2093ab
          Author: Greg Hogan <code@greghogan.com>
          Date: 2017-07-07T13:17:33Z

          FLINK-7132 [java] Fix BulkIteration parallelism

          Copy the parallelism when translating a BulkIteration.


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user greghogan opened a pull request: https://github.com/apache/flink/pull/4283 FLINK-7132 [java] Fix BulkIteration parallelism Copy the parallelism when translating a BulkIteration. `translateBulkIteration` now mirrors the setup of the following function `translateDeltaIteration`. You can merge this pull request into a Git repository by running: $ git pull https://github.com/greghogan/flink 7132_fix_bulkiteration_parallelism Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/4283.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4283 commit c4d3d48eb5467630d7f731f1dfa4c9733b2093ab Author: Greg Hogan <code@greghogan.com> Date: 2017-07-07T13:17:33Z FLINK-7132 [java] Fix BulkIteration parallelism Copy the parallelism when translating a BulkIteration.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user StephanEwen commented on the issue:

          https://github.com/apache/flink/pull/4283

          Looks good, thanks!

          Any way this can be guarded by an additional check in one of the existing tests?

          Show
          githubbot ASF GitHub Bot added a comment - Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/4283 Looks good, thanks! Any way this can be guarded by an additional check in one of the existing tests?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user greghogan commented on the issue:

          https://github.com/apache/flink/pull/4283

          Okay, thanks @StephanEwen. I've added a simple starter `BulkIterationTranslationTest` based on your `DeltaIterationTranslationTest`.

          Show
          githubbot ASF GitHub Bot added a comment - Github user greghogan commented on the issue: https://github.com/apache/flink/pull/4283 Okay, thanks @StephanEwen. I've added a simple starter `BulkIterationTranslationTest` based on your `DeltaIterationTranslationTest`.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user StephanEwen commented on the issue:

          https://github.com/apache/flink/pull/4283

          Perfect, thanks.

          +1 to merge this for `master` and `release-1.3`.

          Show
          githubbot ASF GitHub Bot added a comment - Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/4283 Perfect, thanks. +1 to merge this for `master` and `release-1.3`.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/4283

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4283
          Hide
          greghogan Greg Hogan added a comment -

          master: 480ccfb4809871d1a0812442a8e175d82aa186c1
          1.3: 668527373a26c29fa8af23296cb423e116c0ad35

          Show
          greghogan Greg Hogan added a comment - master: 480ccfb4809871d1a0812442a8e175d82aa186c1 1.3: 668527373a26c29fa8af23296cb423e116c0ad35

            People

            • Assignee:
              greghogan Greg Hogan
              Reporter:
              greghogan Greg Hogan
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development