Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-7069

Catch exceptions for each reporter separately

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 1.3.1, 1.4.0
    • Fix Version/s: 1.4.0, 1.3.2
    • Component/s: Metrics
    • Labels:
      None

      Description

      The metric system can be effectively disabled by a reporter that throws exceptions whenever it is notified of adding metrics.

      The reason is that the catching of exceptions isn't granular enough, as this peace of psude code shows:

      addMetric(metric):
      	try
      		for reporter in reporters:
      			reporter.addMetric(metric)
      		metricQueryService.addMetric(metric)
      	catch (e)
      		logError(e)	
      

      If a reporter throws an exception we never even attempt the other reporters, not notify the MQS which disabled metrics in the WebUI.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Zentol Chesnay Schepler
                Reporter:
                Zentol Chesnay Schepler
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: