Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-6937

Fix link markdown in Production Readiness Checklist doc

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.4.0, 1.3.2
    • Component/s: Documentation
    • Labels:
      None

      Issue Links

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user juanpaulo opened a pull request:

        https://github.com/apache/flink/pull/4134

        FLINK-6937 Fix link markdown in Production Readiness Checklist doc

        FLINK-6937 Fix link markdown in Production Readiness Checklist doc

        • [x] General
        • The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
        • The pull request addresses only one issue
        • Each commit in the PR has a meaningful commit message (including the JIRA id)
        • [x] Documentation
        • Documentation has been added for new functionality
        • Old documentation affected by the pull request has been updated
        • JavaDoc for public methods has been added
        • [x] Tests & Build
        • Functionality added by the pull request is covered by tests
        • `mvn clean verify` has been executed successfully locally or a Travis build has passed

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/juanpaulo/flink master

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/flink/pull/4134.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #4134


        commit 934fb9141fd04c89332f83524ed88d8f20849dbf
        Author: Juan Paulo Gutierrez <juanpaulo.gutierrez@gmail.com>
        Date: 2017-06-13T05:31:40Z

        fixed markdown link issue


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user juanpaulo opened a pull request: https://github.com/apache/flink/pull/4134 FLINK-6937 Fix link markdown in Production Readiness Checklist doc FLINK-6937 Fix link markdown in Production Readiness Checklist doc [x] General The pull request references the related JIRA issue (" [FLINK-XXX] Jira title text") The pull request addresses only one issue Each commit in the PR has a meaningful commit message (including the JIRA id) [x] Documentation Documentation has been added for new functionality Old documentation affected by the pull request has been updated JavaDoc for public methods has been added [x] Tests & Build Functionality added by the pull request is covered by tests `mvn clean verify` has been executed successfully locally or a Travis build has passed You can merge this pull request into a Git repository by running: $ git pull https://github.com/juanpaulo/flink master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/4134.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4134 commit 934fb9141fd04c89332f83524ed88d8f20849dbf Author: Juan Paulo Gutierrez <juanpaulo.gutierrez@gmail.com> Date: 2017-06-13T05:31:40Z fixed markdown link issue
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user tzulitai commented on the issue:

        https://github.com/apache/flink/pull/4134

        Nice catch @juanpaulo, merging this.

        Show
        githubbot ASF GitHub Bot added a comment - Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/4134 Nice catch @juanpaulo, merging this.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user tzulitai commented on the issue:

        https://github.com/apache/flink/pull/4134

        btw, please checkout the format of the commit message we use in Flink.
        Ideally, this should be something like:
        `FLINK-6937 [docs] Fix broken link in Production Readiness Checklist`

        Show
        githubbot ASF GitHub Bot added a comment - Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/4134 btw, please checkout the format of the commit message we use in Flink. Ideally, this should be something like: ` FLINK-6937 [docs] Fix broken link in Production Readiness Checklist`
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/flink/pull/4134

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4134
        Hide
        tzulitai Tzu-Li (Gordon) Tai added a comment -

        Fixed for master via 87e1e8fc350544d81b751efd87f725a1413da1f9.
        Fixed for 1.3.2 via 110eaec9f6cce589dbe4155fe4f818cc4654f5d5.

        Thanks for the fix Juan Paulo Gutierrez!

        Show
        tzulitai Tzu-Li (Gordon) Tai added a comment - Fixed for master via 87e1e8fc350544d81b751efd87f725a1413da1f9. Fixed for 1.3.2 via 110eaec9f6cce589dbe4155fe4f818cc4654f5d5. Thanks for the fix Juan Paulo Gutierrez !
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user juanpaulo commented on the issue:

        https://github.com/apache/flink/pull/4134

        > I will fix it this time for you

        cool. thanks!

        Show
        githubbot ASF GitHub Bot added a comment - Github user juanpaulo commented on the issue: https://github.com/apache/flink/pull/4134 > I will fix it this time for you cool. thanks!

          People

          • Assignee:
            Unassigned
            Reporter:
            juanpaulo Juan Paulo Gutierrez
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development