Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-6899

Wrong state array size in NestedMapsStateTable

    Details

      Description

      The NestedMapsStateTable initializes the internal state array with a wrong size which leads to a waste of memory. We should initialize the array with the number of key groups of the assigned range instead of the max parallelism.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user tillrohrmann opened a pull request:

          https://github.com/apache/flink/pull/4107

          FLINK-6899 [state] Create correctly sized state array in NestedMapsStateTable

          cc @StefanRRichter

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/tillrohrmann/flink fixNestedMapsStateTable

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/4107.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #4107


          commit 5d1861539a70475b1652483161a0e66aa95afb53
          Author: Till Rohrmann <trohrmann@apache.org>
          Date: 2017-06-12T13:21:47Z

          FLINK-6899 [state] Create correctly sized state array in NestedMapsStateTable


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/4107 FLINK-6899 [state] Create correctly sized state array in NestedMapsStateTable cc @StefanRRichter You can merge this pull request into a Git repository by running: $ git pull https://github.com/tillrohrmann/flink fixNestedMapsStateTable Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/4107.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4107 commit 5d1861539a70475b1652483161a0e66aa95afb53 Author: Till Rohrmann <trohrmann@apache.org> Date: 2017-06-12T13:21:47Z FLINK-6899 [state] Create correctly sized state array in NestedMapsStateTable
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user StefanRRichter commented on the issue:

          https://github.com/apache/flink/pull/4107

          LGTM +1

          Show
          githubbot ASF GitHub Bot added a comment - Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/4107 LGTM +1
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user tillrohrmann commented on the issue:

          https://github.com/apache/flink/pull/4107

          Thanks for the review @StefanRRichter. Merging this PR.

          Show
          githubbot ASF GitHub Bot added a comment - Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/4107 Thanks for the review @StefanRRichter. Merging this PR.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/4107

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4107
          Hide
          till.rohrmann Till Rohrmann added a comment -

          1.4.0: 7351ec3aee4077736f05bf66cc430590f064cf2b
          1.3.1: a1d70f5730c7186dd4aa02ec5628a19d8c56f6e8

          Show
          till.rohrmann Till Rohrmann added a comment - 1.4.0: 7351ec3aee4077736f05bf66cc430590f064cf2b 1.3.1: a1d70f5730c7186dd4aa02ec5628a19d8c56f6e8

            People

            • Assignee:
              till.rohrmann Till Rohrmann
              Reporter:
              till.rohrmann Till Rohrmann
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development