Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-6859

StateCleaningCountTrigger should not delete timer

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.3.0
    • Fix Version/s: 1.3.1, 1.4.0
    • Component/s: Table API & SQL
    • Labels:
      None

      Description

      The StateCleaningCountTrigger which is used to clean-up inactive state should not delete timers, i.e.. not call deleteProcessingTimeTimer().
      This is an expensive operation.

      We should rather fire the timer and check if we need to clean the state or not.

      What do you think sunjincheng?

        Issue Links

          Activity

          Hide
          sunjincheng121 sunjincheng added a comment -

          Get set of registered timers by namespace. And traverse the timer queue to delete the timers. is really expensive operation. I'll remove it .

          Show
          sunjincheng121 sunjincheng added a comment - Get set of registered timers by namespace. And traverse the timer queue to delete the timers. is really expensive operation. I'll remove it .
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user sunjincheng121 opened a pull request:

          https://github.com/apache/flink/pull/4085

          FLINK-6859[table] remove delete useless times for improve StateClea…

          • [x] General
          • The pull request references the related JIRA issue (FLINK-6859[table] remove delete useless times for improve StateCleaningCountTrigger)
          • The pull request addresses only one issue
          • Each commit in the PR has a meaningful commit message (including the JIRA id)
          • [ ] Documentation
          • Documentation has been added for new functionality
          • Old documentation affected by the pull request has been updated
          • JavaDoc for public methods has been added
          • [x] Tests & Build
          • Functionality added by the pull request is covered by tests
          • `mvn clean verify` has been executed successfully locally or a Travis build has passed

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/sunjincheng121/flink FLINK-6859-PR

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/4085.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #4085


          commit 44c3b0de07c16f9d58d21177a06231425bab2add
          Author: sunjincheng121 <sunjincheng121@gmail.com>
          Date: 2017-06-07T11:46:32Z

          FLINK-6859[table] remove delete useless times for improve StateCleaningCountTrigger


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user sunjincheng121 opened a pull request: https://github.com/apache/flink/pull/4085 FLINK-6859 [table] remove delete useless times for improve StateClea… [x] General The pull request references the related JIRA issue ( FLINK-6859 [table] remove delete useless times for improve StateCleaningCountTrigger) The pull request addresses only one issue Each commit in the PR has a meaningful commit message (including the JIRA id) [ ] Documentation Documentation has been added for new functionality Old documentation affected by the pull request has been updated JavaDoc for public methods has been added [x] Tests & Build Functionality added by the pull request is covered by tests `mvn clean verify` has been executed successfully locally or a Travis build has passed You can merge this pull request into a Git repository by running: $ git pull https://github.com/sunjincheng121/flink FLINK-6859 -PR Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/4085.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4085 commit 44c3b0de07c16f9d58d21177a06231425bab2add Author: sunjincheng121 <sunjincheng121@gmail.com> Date: 2017-06-07T11:46:32Z FLINK-6859 [table] remove delete useless times for improve StateCleaningCountTrigger
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user fhueske commented on the issue:

          https://github.com/apache/flink/pull/4085

          +1 to merge

          Show
          githubbot ASF GitHub Bot added a comment - Github user fhueske commented on the issue: https://github.com/apache/flink/pull/4085 +1 to merge
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user zentol commented on the issue:

          https://github.com/apache/flink/pull/4085

          merging.

          Show
          githubbot ASF GitHub Bot added a comment - Github user zentol commented on the issue: https://github.com/apache/flink/pull/4085 merging.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/4085

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4085
          Hide
          Zentol Chesnay Schepler added a comment -

          1.4: 92cd736daf65aae10f77bb6e8144623a5c82b5be

          Show
          Zentol Chesnay Schepler added a comment - 1.4: 92cd736daf65aae10f77bb6e8144623a5c82b5be
          Hide
          Zentol Chesnay Schepler added a comment -

          haven't merged it for 1.3 yet.

          Show
          Zentol Chesnay Schepler added a comment - haven't merged it for 1.3 yet.
          Hide
          Zentol Chesnay Schepler added a comment -

          1.3: 007dc01b55439c65b71ec354feb382247c741cce

          Show
          Zentol Chesnay Schepler added a comment - 1.3: 007dc01b55439c65b71ec354feb382247c741cce
          Hide
          Zentol Chesnay Schepler added a comment -

          It appears i still didn't merge it.

          Show
          Zentol Chesnay Schepler added a comment - It appears i still didn't merge it.
          Hide
          fhueske Fabian Hueske added a comment -

          I'll merge it to 1.3

          Show
          fhueske Fabian Hueske added a comment - I'll merge it to 1.3
          Hide
          fhueske Fabian Hueske added a comment -

          Fixed for 1.3.1 with 78b5092dc82fe36412e1d47c1a1fd81ef821d7c6

          Show
          fhueske Fabian Hueske added a comment - Fixed for 1.3.1 with 78b5092dc82fe36412e1d47c1a1fd81ef821d7c6

            People

            • Assignee:
              sunjincheng121 sunjincheng
              Reporter:
              fhueske Fabian Hueske
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development