Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-6816

Fix wrong usage of Scala string interpolation in Table API

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.3.1, 1.4.0
    • Component/s: Table API & SQL
    • Labels:
      None

      Description

      This issue is to fix some wrong usage of Scala string interpolation, such as missing the "s" prefix .

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user wuchong opened a pull request:

          https://github.com/apache/flink/pull/4050

          FLINK-6816 [table] Fix wrong usage of Scala string interpolation in Table API

          Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
          If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
          In addition to going through the list, please provide a meaningful description of your changes.

          • [ ] General
          • The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
          • The pull request addresses only one issue
          • Each commit in the PR has a meaningful commit message (including the JIRA id)
          • [ ] Documentation
          • Documentation has been added for new functionality
          • Old documentation affected by the pull request has been updated
          • JavaDoc for public methods has been added
          • [ ] Tests & Build
          • Functionality added by the pull request is covered by tests
          • `mvn clean verify` has been executed successfully locally or a Travis build has passed

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/wuchong/flink string-interpolation

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/4050.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #4050


          commit f33f2fe85cd08aa6d8934fe8477fbab617903389
          Author: Jark Wu <wuchong.wc@alibaba-inc.com>
          Date: 2017-06-02T13:15:55Z

          FLINK-6816 [table] Fix wrong usage of Scala string interpolation in Table API


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user wuchong opened a pull request: https://github.com/apache/flink/pull/4050 FLINK-6816 [table] Fix wrong usage of Scala string interpolation in Table API Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration. If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide] ( http://flink.apache.org/how-to-contribute.html ). In addition to going through the list, please provide a meaningful description of your changes. [ ] General The pull request references the related JIRA issue (" [FLINK-XXX] Jira title text") The pull request addresses only one issue Each commit in the PR has a meaningful commit message (including the JIRA id) [ ] Documentation Documentation has been added for new functionality Old documentation affected by the pull request has been updated JavaDoc for public methods has been added [ ] Tests & Build Functionality added by the pull request is covered by tests `mvn clean verify` has been executed successfully locally or a Travis build has passed You can merge this pull request into a Git repository by running: $ git pull https://github.com/wuchong/flink string-interpolation Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/4050.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4050 commit f33f2fe85cd08aa6d8934fe8477fbab617903389 Author: Jark Wu <wuchong.wc@alibaba-inc.com> Date: 2017-06-02T13:15:55Z FLINK-6816 [table] Fix wrong usage of Scala string interpolation in Table API
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user zentol commented on the issue:

          https://github.com/apache/flink/pull/4050

          +1.

          Show
          githubbot ASF GitHub Bot added a comment - Github user zentol commented on the issue: https://github.com/apache/flink/pull/4050 +1.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user sunjincheng121 commented on a diff in the pull request:

          https://github.com/apache/flink/pull/4050#discussion_r119915689

          — Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/ProcTimeBoundedRangeOver.scala —
          @@ -62,8 +62,8 @@ class ProcTimeBoundedRangeOver(
          private var function: GeneratedAggregations = _

          override def open(config: Configuration) {

          • LOG.debug(s"Compiling AggregateHelper: $genAggregations.name \n\n " +
          • s"Code:\n$genAggregations.code")
            + LOG.debug(s"Compiling AggregateHelper: $ {genAggregations.name} \n\n " +
            — End diff –

            I think we supported remove the " ", i.e.:
            `${genAggregations.name}

            \n\n "` -> `$

            {genAggregations.name}

            \n\n"`
            If we do this change, the log print info as follows:
            FROM
            ```
            Compiling AggregateHelper: MinMaxAggregateHelper

          Code:
          GeneratedAggregationsFunction(MinMaxAggregateHelper,
          ```
          TO
          ```
          Compiling AggregateHelper: MinMaxAggregateHelper

          Code:
          GeneratedAggregationsFunction(MinMaxAggregateHelper,
          ```

          Show
          githubbot ASF GitHub Bot added a comment - Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/4050#discussion_r119915689 — Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/ProcTimeBoundedRangeOver.scala — @@ -62,8 +62,8 @@ class ProcTimeBoundedRangeOver( private var function: GeneratedAggregations = _ override def open(config: Configuration) { LOG.debug(s"Compiling AggregateHelper: $genAggregations.name \n\n " + s"Code:\n$genAggregations.code") + LOG.debug(s"Compiling AggregateHelper: $ {genAggregations.name} \n\n " + — End diff – I think we supported remove the " ", i.e.: `${genAggregations.name} \n\n "` -> `$ {genAggregations.name} \n\n"` If we do this change, the log print info as follows: FROM ``` Compiling AggregateHelper: MinMaxAggregateHelper Code: GeneratedAggregationsFunction(MinMaxAggregateHelper, ``` TO ``` Compiling AggregateHelper: MinMaxAggregateHelper Code: GeneratedAggregationsFunction(MinMaxAggregateHelper, ```
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user wuchong commented on the issue:

          https://github.com/apache/flink/pull/4050

          @sunjincheng121 I've addressed your suggestion.

          Show
          githubbot ASF GitHub Bot added a comment - Github user wuchong commented on the issue: https://github.com/apache/flink/pull/4050 @sunjincheng121 I've addressed your suggestion.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user sunjincheng121 commented on the issue:

          https://github.com/apache/flink/pull/4050

          Hi @wuchong Thanks for the update.
          +1 to merged.

          Show
          githubbot ASF GitHub Bot added a comment - Github user sunjincheng121 commented on the issue: https://github.com/apache/flink/pull/4050 Hi @wuchong Thanks for the update. +1 to merged.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user twalthr commented on the issue:

          https://github.com/apache/flink/pull/4050

          Thanks @wuchong. I will merge this.

          Show
          githubbot ASF GitHub Bot added a comment - Github user twalthr commented on the issue: https://github.com/apache/flink/pull/4050 Thanks @wuchong. I will merge this.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/4050

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4050
          Hide
          twalthr Timo Walther added a comment -

          Fixed in 1.4: 762141e55639e76d5aa9940d00975601817b6197
          Fixed in 1.3.1: fdcdb16985a2d72634067c9a8fc86c9ac4f99e1c

          Show
          twalthr Timo Walther added a comment - Fixed in 1.4: 762141e55639e76d5aa9940d00975601817b6197 Fixed in 1.3.1: fdcdb16985a2d72634067c9a8fc86c9ac4f99e1c

            People

            • Assignee:
              jark Jark Wu
              Reporter:
              jark Jark Wu
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development