Details
-
Sub-task
-
Status: Closed
-
Major
-
Resolution: Won't Fix
-
None
-
None
-
None
Description
Long term issue for incrementally introducing the strict checkstyle to flink-runtime.
As proposed in https://github.com/apache/flink/pull/4032 we will introduce the checkstyle incrementally by package.
The following is a list of all packages under org/apache/flink/runtime and their respective checkstyle violations:
akka 25 blob 140 broadcast 94 checkpoint 381 client 83 clusterframework 281 concurrent 33 deployment 27 event 17 execution 74 executiongraph 881 filecache 33 fs 62 heartbeat 30 highavailability 94 instance 370 io 1592 iterative 316 jobgraph 283 jobmanager 717 jobmaster 84 leaderelection 54 leaderretrieval 11 memory 249 messages 135 minicluster 53 net 46 operators 7953 plugable 27 process 1 query 106 registration 43 resourcemanager 114 rpc 127 security 58 state 463 taskexecutor 153 taskmanager 343 testutils 204 util 536
metrics, history and webmonitor are excluded from this list, as I'm not aware of any large-scale issue/feature branch for any of then.
There are a number of low-hanging fruits in there for which we could apply the checkstyle regardless of current efforts in there, like process, or leaderretrieval.
I will reach out to committers that are active in the runtime components to see which of these we could modify without causing to much problems.
Attachments
Issue Links
- is a child of
-
FLINK-6793 Activate checkstyle for runtime/metrics
-
- Closed
-
-
FLINK-6794 Activate checkstyle for migration/*
-
- Closed
-
-
FLINK-6795 Activate checkstyle for runtime/process
-
- Closed
-
-
FLINK-6818 Activate checkstyle for runtime/history
-
- Closed
-
-
FLINK-6819 Activate checkstyle for runtime/leaderretrieval
-
- Closed
-
-
FLINK-6820 Activate checkstyle for runtime/filecache
-
- Closed
-
-
FLINK-6821 Activate checkstyle for runtime/fs
-
- Closed
-
-
FLINK-6822 Activate checkstyle for runtime/plugable
-
- Closed
-
-
FLINK-6823 Activate checkstyle for runtime/broadcast
-
- Closed
-
-
FLINK-6824 Activate checkstyle for runtime/event
-
- Closed
-
-
FLINK-6825 Activate checkstyle for runtime/heartbeat
-
- Closed
-
-
FLINK-6826 Activate checkstyle for runtime/net
-
- Closed
-
-
FLINK-6827 Activate checkstyle for runtime/webmonitor
-
- Closed
-
-
FLINK-6828 Activate checkstyle for runtime/deployment
-
- Closed
-
-
FLINK-6831 Activate checkstyle for runtime/*
-
- Closed
-
-
FLINK-6877 Activate checkstyle for runtime/security
-
- Closed
-
-
FLINK-6878 Activate checkstyle for runtime/query
-
- Closed
-
-
FLINK-6880 Activate checkstyle for runtime/iterative
-
- Closed
-
-
FLINK-6882 Activate checkstyle for runtime/registration
-
- Closed
-
-
FLINK-6903 Activate checkstyle for runtime/akka
-
- Closed
-
-
FLINK-7257 Extend flink-runtime checkstyle coverage to tests
-
- Closed
-