Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-6702

SIGABRT after CEPOperatorTest#testCEPOperatorSerializationWRocksDB() during GC

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.3.0
    • Fix Version/s: 1.3.0, 1.4.0
    • Component/s: CEP, Tests
    • Labels:
      None

      Description

      During the CEP unit tests, when garbage collection kicks in and tries to finalize RocksDB, it may fail with

      pure virtual method called
      terminate called without an active exception
      Process finished with exit code 134 (interrupted by signal 6: SIGABRT)
      

      Reason is a missing harness.close() call in CEPOperatorTest#testCEPOperatorSerializationWRocksDB().

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user NicoK commented on a diff in the pull request:

          https://github.com/apache/flink/pull/3978#discussion_r118260352

          — Diff: flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/operator/CEPOperatorTest.java —
          @@ -654,6 +654,7 @@ public boolean filter(Event value) throws Exception {
          Lists.newArrayList(startEvent2, endEvent, middleEvent3)
          )
          );
          + harness.close();
          — End diff –

          ok, did that - would have been nice to use try-with-resources but I didn't want to change too much and an operator's `close()` method does allow throwing `Exception`s and so should `AbstractStreamOperatorTestHarness#close()` (probably)

          Show
          githubbot ASF GitHub Bot added a comment - Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/3978#discussion_r118260352 — Diff: flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/operator/CEPOperatorTest.java — @@ -654,6 +654,7 @@ public boolean filter(Event value) throws Exception { Lists.newArrayList(startEvent2, endEvent, middleEvent3) ) ); + harness.close(); — End diff – ok, did that - would have been nice to use try-with-resources but I didn't want to change too much and an operator's `close()` method does allow throwing `Exception`s and so should `AbstractStreamOperatorTestHarness#close()` (probably)
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user zentol commented on the issue:

          https://github.com/apache/flink/pull/3978

          Looks good. I will merge this after #3976 to avoid merge conflicts.

          Show
          githubbot ASF GitHub Bot added a comment - Github user zentol commented on the issue: https://github.com/apache/flink/pull/3978 Looks good. I will merge this after #3976 to avoid merge conflicts.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user zentol commented on the issue:

          https://github.com/apache/flink/pull/3978

          I'll merge this now.

          Show
          githubbot ASF GitHub Bot added a comment - Github user zentol commented on the issue: https://github.com/apache/flink/pull/3978 I'll merge this now.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/3978

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3978
          Hide
          Zentol Chesnay Schepler added a comment -

          1.3: 4123ce6cd4cdbca326e07e2b6563ca3ed482705e &
          97c41f62cbe5a3fa276bf56effe9297b3ad4a8c7

          1.4: d5ab6361967fcfc41415f8d5ebca0b0ef5928f88 & 38c45f8052166b93bfeebe7aed88a16c53a9332a

          Show
          Zentol Chesnay Schepler added a comment - 1.3: 4123ce6cd4cdbca326e07e2b6563ca3ed482705e & 97c41f62cbe5a3fa276bf56effe9297b3ad4a8c7 1.4: d5ab6361967fcfc41415f8d5ebca0b0ef5928f88 & 38c45f8052166b93bfeebe7aed88a16c53a9332a

            People

            • Assignee:
              NicoK Nico Kruber
              Reporter:
              NicoK Nico Kruber
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development