Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-6685

SafetyNetCloseableRegistry is closed prematurely in Task::triggerCheckpointBarrier

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 1.3.0
    • Fix Version/s: 1.3.1, 1.4.0
    • Component/s: None
    • Labels:
      None

      Description

      The SafetyNetCloseableRegistry is closed to early in triggerCheckpointBarrier(...). Right now, it seems like the code assumes that statefulTask.triggerCheckpoint(...) is blocking - which it is not. Like this, the registry can be closed while the checkpoint is still running.

        Issue Links

          Activity

          Hide
          srichter Stefan Richter added a comment -

          For the release, we can fix this by reusing the registry from the task scope and not closing it on a per-checkpoint scope.

          In the future, we should fix this properly by implementing the changes suggested in FLINK-6684.

          Show
          srichter Stefan Richter added a comment - For the release, we can fix this by reusing the registry from the task scope and not closing it on a per-checkpoint scope. In the future, we should fix this properly by implementing the changes suggested in FLINK-6684 .
          Hide
          srichter Stefan Richter added a comment -

          fixed in 7639d49e03

          Show
          srichter Stefan Richter added a comment - fixed in 7639d49e03
          Hide
          gyfora Gyula Fora added a comment -

          Thanks Stefan, awesome job! I can confirm that this solves our savepoint issues

          Show
          gyfora Gyula Fora added a comment - Thanks Stefan, awesome job! I can confirm that this solves our savepoint issues
          Hide
          srichter Stefan Richter added a comment -

          Fix was incomplete.

          Show
          srichter Stefan Richter added a comment - Fix was incomplete.
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user StefanRRichter opened a pull request:

          https://github.com/apache/flink/pull/4108

          FLINK-6685 Adjust scopes of SafetyNetCloseableRegistry usage

          This PR addresses remaining issues with the `SafetyNetCloseableregistry`:

          • reset the registry to `null` after usage in `Task`.
          • use the registry in the scope of the async checkpointing thread.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/StefanRRichter/flink adjustSafetyNetScope

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/4108.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #4108


          commit e2031db5f9171d692a41f04d1f3d1ebf592ef6b1
          Author: Stefan Richter <s.richter@data-artisans.com>
          Date: 2017-06-12T09:48:15Z

          FLINK-6685 Adjust scopes of SafetyNetCloseableRegistry usage


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user StefanRRichter opened a pull request: https://github.com/apache/flink/pull/4108 FLINK-6685 Adjust scopes of SafetyNetCloseableRegistry usage This PR addresses remaining issues with the `SafetyNetCloseableregistry`: reset the registry to `null` after usage in `Task`. use the registry in the scope of the async checkpointing thread. You can merge this pull request into a Git repository by running: $ git pull https://github.com/StefanRRichter/flink adjustSafetyNetScope Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/4108.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4108 commit e2031db5f9171d692a41f04d1f3d1ebf592ef6b1 Author: Stefan Richter <s.richter@data-artisans.com> Date: 2017-06-12T09:48:15Z FLINK-6685 Adjust scopes of SafetyNetCloseableRegistry usage
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/4108

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4108
          Hide
          till.rohrmann Till Rohrmann added a comment -

          1.4.0: 68ac96e16c09d7aee64d3dc0e5629cc308fb087f
          1.3.1: 8de51f953421a30073d2ff57bf37daa81bdaa991

          Show
          till.rohrmann Till Rohrmann added a comment - 1.4.0: 68ac96e16c09d7aee64d3dc0e5629cc308fb087f 1.3.1: 8de51f953421a30073d2ff57bf37daa81bdaa991
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user StefanRRichter commented on the issue:

          https://github.com/apache/flink/pull/4108

          @tillrohrmann thanks for the review and the merge!

          Show
          githubbot ASF GitHub Bot added a comment - Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/4108 @tillrohrmann thanks for the review and the merge!

            People

            • Assignee:
              srichter Stefan Richter
              Reporter:
              srichter Stefan Richter
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development