Details

      Description

      To let the ResourceStrategy work across multiple FailoverStrategy implementations, it needs to be passed a "callback" to call to trigger the restart of tasks/regions/etc.

      Such a "callback" would be a nice abstraction to use for global restarts as well, to not expose the full execution graph.

      Ideally, the callback is one-shot, so it cannot accidentally be used to call restart() multiple times.

      This would also make the testing of RestartStrategies much easier.

        Issue Links

          Activity

          Hide
          aljoscha Aljoscha Krettek added a comment -

          Fixed in

          • 1.4.0 via 65400bd0a0f6a3bdd3e0bad05e2179534eaf6e9e
          • 1.3.2 via 65400bd0a0f6a3bdd3e0bad05e2179534eaf6e9e

          1.3.2 needed to be fixed because this was a blocker for a critical bug fix

          Show
          aljoscha Aljoscha Krettek added a comment - Fixed in 1.4.0 via 65400bd0a0f6a3bdd3e0bad05e2179534eaf6e9e 1.3.2 via 65400bd0a0f6a3bdd3e0bad05e2179534eaf6e9e 1.3.2 needed to be fixed because this was a blocker for a critical bug fix
          Hide
          aljoscha Aljoscha Krettek added a comment -

          Reopen to fix release version.

          Show
          aljoscha Aljoscha Krettek added a comment - Reopen to fix release version.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user zjureel closed the pull request at:

          https://github.com/apache/flink/pull/4277

          Show
          githubbot ASF GitHub Bot added a comment - Github user zjureel closed the pull request at: https://github.com/apache/flink/pull/4277
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user zjureel commented on the issue:

          https://github.com/apache/flink/pull/4277

          Thank you for your merging, thanks

          Show
          githubbot ASF GitHub Bot added a comment - Github user zjureel commented on the issue: https://github.com/apache/flink/pull/4277 Thank you for your merging, thanks
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user StephanEwen commented on the issue:

          https://github.com/apache/flink/pull/4277

          Thank you for the contribution!
          The code form this PR has been improved and merged in this commit: 65400bd0a0f6a3bdd3e0bad05e2179534eaf6e9e

          If you agree, could you close this PR?

          Show
          githubbot ASF GitHub Bot added a comment - Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/4277 Thank you for the contribution! The code form this PR has been improved and merged in this commit: 65400bd0a0f6a3bdd3e0bad05e2179534eaf6e9e If you agree, could you close this PR?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user StephanEwen commented on the issue:

          https://github.com/apache/flink/pull/4277

          I have taken and adapted the code for the patch in #4364

          Show
          githubbot ASF GitHub Bot added a comment - Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/4277 I have taken and adapted the code for the patch in #4364
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user zjureel commented on the issue:

          https://github.com/apache/flink/pull/4277

          Thank you for your reply, I will fix FLINK-6665(https://issues.apache.org/jira/browse/FLINK-6665) after this PR is merged, thanks

          Show
          githubbot ASF GitHub Bot added a comment - Github user zjureel commented on the issue: https://github.com/apache/flink/pull/4277 Thank you for your reply, I will fix FLINK-6665 ( https://issues.apache.org/jira/browse/FLINK-6665 ) after this PR is merged, thanks
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user StephanEwen commented on the issue:

          https://github.com/apache/flink/pull/4277

          @zjureel Thanks for this patch. I will pick it up from here.
          I think there is a small additional change needed, and a test, but I can do that...

          Show
          githubbot ASF GitHub Bot added a comment - Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/4277 @zjureel Thanks for this patch. I will pick it up from here. I think there is a small additional change needed, and a test, but I can do that...
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user zjureel commented on the issue:

          https://github.com/apache/flink/pull/4277

          @StephanEwen @tillrohrmann As discussed in https://github.com/apache/flink/pull/4220, I create this PR to fix issue FLINK-6667(https://issues.apache.org/jira/browse/FLINK-6667). Could you please have a look when you're free, thanks

          Show
          githubbot ASF GitHub Bot added a comment - Github user zjureel commented on the issue: https://github.com/apache/flink/pull/4277 @StephanEwen @tillrohrmann As discussed in https://github.com/apache/flink/pull/4220 , I create this PR to fix issue FLINK-6667 ( https://issues.apache.org/jira/browse/FLINK-6667 ). Could you please have a look when you're free, thanks
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user zjureel opened a pull request:

          https://github.com/apache/flink/pull/4277

          FLINK-6667 Pass a callback type to the RestartStrategy, rather than the full ExecutionGraph

          … the full ExecutionGraph

          Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
          If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
          In addition to going through the list, please provide a meaningful description of your changes.

          • [ ] General
          • The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
          • The pull request addresses only one issue
          • Each commit in the PR has a meaningful commit message (including the JIRA id)
          • [ ] Documentation
          • Documentation has been added for new functionality
          • Old documentation affected by the pull request has been updated
          • JavaDoc for public methods has been added
          • [ ] Tests & Build
          • Functionality added by the pull request is covered by tests
          • `mvn clean verify` has been executed successfully locally or a Travis build has passed

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/zjureel/flink FLINK-6667

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/4277.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #4277


          commit e1b8b8ca4a8d1bbff61a6de8547eaf1c2e140669
          Author: zjureel <zjureel@gmail.com>
          Date: 2017-07-07T02:37:42Z

          FLINK-6667 Pass a callback type to the RestartStrategy, rather than the full ExecutionGraph


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user zjureel opened a pull request: https://github.com/apache/flink/pull/4277 FLINK-6667 Pass a callback type to the RestartStrategy, rather than the full ExecutionGraph … the full ExecutionGraph Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration. If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide] ( http://flink.apache.org/how-to-contribute.html ). In addition to going through the list, please provide a meaningful description of your changes. [ ] General The pull request references the related JIRA issue (" [FLINK-XXX] Jira title text") The pull request addresses only one issue Each commit in the PR has a meaningful commit message (including the JIRA id) [ ] Documentation Documentation has been added for new functionality Old documentation affected by the pull request has been updated JavaDoc for public methods has been added [ ] Tests & Build Functionality added by the pull request is covered by tests `mvn clean verify` has been executed successfully locally or a Travis build has passed You can merge this pull request into a Git repository by running: $ git pull https://github.com/zjureel/flink FLINK-6667 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/4277.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4277 commit e1b8b8ca4a8d1bbff61a6de8547eaf1c2e140669 Author: zjureel <zjureel@gmail.com> Date: 2017-07-07T02:37:42Z FLINK-6667 Pass a callback type to the RestartStrategy, rather than the full ExecutionGraph

            People

            • Assignee:
              zjureel Fang Yong
              Reporter:
              StephanEwen Stephan Ewen
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development