Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-6659

RocksDBMergeIteratorTest, SavepointITCase leave temporary directories behind

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.2.0, 1.3.0, 1.2.1, 1.2.2
    • Fix Version/s: 1.3.1, 1.4.0
    • Component/s: Tests
    • Labels:
      None

      Description

      RocksDBMergeIteratorTest uses a newly created temporary directory (via CommonTestUtils.createTempDirectory()) for its RocksDB instance but does not delete is when finished. We should better replace this pattern with a proper @Rule-based approach

        Issue Links

          Activity

          Hide
          NicoK Nico Kruber added a comment -

          SavepointITCase follows a similar pattern and should be revised

          Show
          NicoK Nico Kruber added a comment - SavepointITCase follows a similar pattern and should be revised
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user NicoK opened a pull request:

          https://github.com/apache/flink/pull/3962

          FLINK-6659 fix (some) unit tests leaving temporary data behind

          Both, `RocksDBMergeIteratorTest` as well as `SavepointITCase` were using `CommonTestUtils.createTempDirectory()` to create a temporary directory and never deleted it after the test finishes. This PR replaces this usage by a JUnit `@Rule` instead.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/NicoK/flink flink-6659

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/3962.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #3962


          commit 79cf9958a2325359c04fa2050264a8c1a3525d13
          Author: Nico Kruber <nico@data-artisans.com>
          Date: 2017-05-22T14:47:35Z

          FLINK-6659 fix RocksDBMergeIteratorTest leaving temporary data behind

          -> use a JUnit '@Rule' that does the cleanup

          commit 77fec6c6a8c771622c89590661bb005ffa3f5488
          Author: Nico Kruber <nico@data-artisans.com>
          Date: 2017-05-22T14:55:39Z

          FLINK-6659 fix SavepointITCase leaving temporary data behind

          -> use a JUnit '@Rule' that does the cleanup


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user NicoK opened a pull request: https://github.com/apache/flink/pull/3962 FLINK-6659 fix (some) unit tests leaving temporary data behind Both, `RocksDBMergeIteratorTest` as well as `SavepointITCase` were using `CommonTestUtils.createTempDirectory()` to create a temporary directory and never deleted it after the test finishes. This PR replaces this usage by a JUnit `@Rule` instead. You can merge this pull request into a Git repository by running: $ git pull https://github.com/NicoK/flink flink-6659 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3962.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3962 commit 79cf9958a2325359c04fa2050264a8c1a3525d13 Author: Nico Kruber <nico@data-artisans.com> Date: 2017-05-22T14:47:35Z FLINK-6659 fix RocksDBMergeIteratorTest leaving temporary data behind -> use a JUnit '@Rule' that does the cleanup commit 77fec6c6a8c771622c89590661bb005ffa3f5488 Author: Nico Kruber <nico@data-artisans.com> Date: 2017-05-22T14:55:39Z FLINK-6659 fix SavepointITCase leaving temporary data behind -> use a JUnit '@Rule' that does the cleanup
          Hide
          StephanEwen Stephan Ewen added a comment -

          Should we just drop the CommonTestUtils.createTempDirectory() method, to not encourage use of that pattern?

          Show
          StephanEwen Stephan Ewen added a comment - Should we just drop the CommonTestUtils.createTempDirectory() method, to not encourage use of that pattern?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user zentol commented on the issue:

          https://github.com/apache/flink/pull/3962

          +1.

          Show
          githubbot ASF GitHub Bot added a comment - Github user zentol commented on the issue: https://github.com/apache/flink/pull/3962 +1.
          Hide
          Zentol Chesnay Schepler added a comment -

          + to remove the method.

          Show
          Zentol Chesnay Schepler added a comment - + to remove the method.
          Hide
          NicoK Nico Kruber added a comment -

          (I created the follow-up FLINK-6670 to remove the method)

          Show
          NicoK Nico Kruber added a comment - (I created the follow-up FLINK-6670 to remove the method)
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user zentol commented on the issue:

          https://github.com/apache/flink/pull/3962

          merging.

          Show
          githubbot ASF GitHub Bot added a comment - Github user zentol commented on the issue: https://github.com/apache/flink/pull/3962 merging.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/3962

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3962
          Hide
          Zentol Chesnay Schepler added a comment -

          1.3: 0824333ead39ed383be10e5a1fe13440dbd5fa88 & 4767f84b4c22fba40de31a3c0c81dfc97cec6a7e
          1.4: b58a420e3954f734192a7eff2e187349c4ed9959 & fe6714760b0feb688aa2e8169b1a73028e42afd4

          Marked as fixed for 1.3.1 as I'm not sure if it will be included in 1.3.

          Show
          Zentol Chesnay Schepler added a comment - 1.3: 0824333ead39ed383be10e5a1fe13440dbd5fa88 & 4767f84b4c22fba40de31a3c0c81dfc97cec6a7e 1.4: b58a420e3954f734192a7eff2e187349c4ed9959 & fe6714760b0feb688aa2e8169b1a73028e42afd4 Marked as fixed for 1.3.1 as I'm not sure if it will be included in 1.3.

            People

            • Assignee:
              NicoK Nico Kruber
              Reporter:
              NicoK Nico Kruber
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development