[FLINK-6618] Fix GroupWindowStringExpressionTest testcase bug

• Type: Sub-task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.3.0
• Fix Version/s: 1.3.0, 1.4.0
• Component/s: Table SQL / API
• Assignee: sunjincheng
• Reporter: sunjincheng
• Created: 18/May/17 03:33
• Updated: 18/Sep/18 09:40
• Resolved: 18/May/17 20:09

Description

I find 2 bugs as follows:

1. GroupWindowStringExpressionTest testcase bug:

Assert.assertEquals("Logical Plans do not match", resJava.logicalPlan, resJava.logicalPlan) -> verifyTableEquals(resJava, resScala)

2. Window properties can not select in JAVA API:
Java Code:

 // String / Java API
    val resJava = t
      .window(JSlide.over("4.hours").every("2.hours").on("rowtime") as 'w)
      .groupBy("w, string")
      .select(
        "string, " +
        "myCountFun(string), " +
        "int.sum, " +
        "weightAvgFun(long, int), " +
        "weightAvgFun(int, int) * 2, " +
        "start(w)," +
        "end(w)")

Exception Info:

org.apache.flink.table.api.ValidationException: Cannot resolve [w] given input [int, long, string, rowtime].

	at org.apache.flink.table.plan.logical.LogicalNode.failValidation(LogicalNode.scala:143)
	at org.apache.flink.table.plan.logical.LogicalNode$$anonfun$validate$1.applyOrElse(LogicalNode.scala:86)
	at org.apache.flink.table.plan.logical.LogicalNode$$anonfun$validate$1.applyOrElse(LogicalNode.scala:83)
	at org.apache.flink.table.plan.TreeNode.postOrderTransform(TreeNode.scala:72)
	at org.apache.flink.table.plan.logical.LogicalNode.org$apache$flink$table$plan$logical$LogicalNode$$expressionPostOrderTransform$1(LogicalNode.scala:119)
	at org.apache.flink.table.plan.logical.LogicalNode$$anonfun$7$$anonfun$apply$1.apply(LogicalNode.scala:132)
	at scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:244)
	at scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:244)
	at scala.collection.mutable.ResizableArray$class.foreach(ResizableArray.scala:59)
 

Issue Links

• is required by: FLINK-6617 Improve JAVA and SCALA logical plans consistent test
• links to: GitHub Pull Request #3936