Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-6551

OutputTag name should not be allowed to be empty

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.3.0, 1.4.0
    • Fix Version/s: 1.3.0, 1.4.0
    • Component/s: DataStream API
    • Labels:
      None

      Description

      When creating an OutputTag it is required to give it a name.

      While we do enforce that the name is not null we do not have a check in place that prevents passing an empty string.

        Issue Links

          Activity

          Hide
          Zentol Chesnay Schepler added a comment -

          1.3: c35a177fed10668da31674b726847d0756a7aeca
          1.4: b9e75ff0efeb0fe604f7e55b48291de1e9f6a752

          Show
          Zentol Chesnay Schepler added a comment - 1.3: c35a177fed10668da31674b726847d0756a7aeca 1.4: b9e75ff0efeb0fe604f7e55b48291de1e9f6a752
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/3953

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3953
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user zentol commented on the issue:

          https://github.com/apache/flink/pull/3953

          merging.

          Show
          githubbot ASF GitHub Bot added a comment - Github user zentol commented on the issue: https://github.com/apache/flink/pull/3953 merging.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user greghogan commented on the issue:

          https://github.com/apache/flink/pull/3953

          +1

          Show
          githubbot ASF GitHub Bot added a comment - Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3953 +1
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user zentol opened a pull request:

          https://github.com/apache/flink/pull/3953

          FLINK-6551 Reject empty OutputTag names

          With this PR we reject empty `OutputTag` names. Having an empty name prevents useful logging messages, as they would effectively contain no information about the tag.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/zentol/flink 6551_outputtag_empty

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/3953.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #3953


          commit 7e8a2f0cfd30466de1c99195a70992e92364efbc
          Author: zentol <chesnay@apache.org>
          Date: 2017-05-19T14:20:05Z

          FLINK-6551 Reject empty OutputTag names


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/3953 FLINK-6551 Reject empty OutputTag names With this PR we reject empty `OutputTag` names. Having an empty name prevents useful logging messages, as they would effectively contain no information about the tag. You can merge this pull request into a Git repository by running: $ git pull https://github.com/zentol/flink 6551_outputtag_empty Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3953.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3953 commit 7e8a2f0cfd30466de1c99195a70992e92364efbc Author: zentol <chesnay@apache.org> Date: 2017-05-19T14:20:05Z FLINK-6551 Reject empty OutputTag names

            People

            • Assignee:
              Zentol Chesnay Schepler
              Reporter:
              Zentol Chesnay Schepler
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development