Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-6492

Unclosed DataOutputViewStream in GenericArraySerializerConfigSnapshot#write()

    Details

      Description

         InstantiationUtil.serializeObject(new DataOutputViewStream(out), componentClass);
      

      DataOutputViewStream instance should be closed upon return.

      TupleSerializerConfigSnapshot has similar issue.

        Issue Links

          Activity

          Hide
          HuafengWang Huafeng Wang added a comment -

          If nobody is woking on this, I'd like to take this one.

          Show
          HuafengWang Huafeng Wang added a comment - If nobody is woking on this, I'd like to take this one.
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user huafengw opened a pull request:

          https://github.com/apache/flink/pull/3898

          FLINK-6492 Fix unclosed DataOutputViewStream usage

          Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
          If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
          In addition to going through the list, please provide a meaningful description of your changes.

          • [ ] General
          • The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
          • The pull request addresses only one issue
          • Each commit in the PR has a meaningful commit message (including the JIRA id)
          • [ ] Documentation
          • Documentation has been added for new functionality
          • Old documentation affected by the pull request has been updated
          • JavaDoc for public methods has been added
          • [ ] Tests & Build
          • Functionality added by the pull request is covered by tests
          • `mvn clean verify` has been executed successfully locally or a Travis build has passed

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/huafengw/flink fix6492

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/3898.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #3898


          commit 3a2e981efd5fffd25d551331af5b422a0812e802
          Author: huafengw <fvunicorn@gmail.com>
          Date: 2017-05-15T07:56:19Z

          FLINK-6492 Fix unclosed DataOutputViewStream usage


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user huafengw opened a pull request: https://github.com/apache/flink/pull/3898 FLINK-6492 Fix unclosed DataOutputViewStream usage Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration. If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide] ( http://flink.apache.org/how-to-contribute.html ). In addition to going through the list, please provide a meaningful description of your changes. [ ] General The pull request references the related JIRA issue (" [FLINK-XXX] Jira title text") The pull request addresses only one issue Each commit in the PR has a meaningful commit message (including the JIRA id) [ ] Documentation Documentation has been added for new functionality Old documentation affected by the pull request has been updated JavaDoc for public methods has been added [ ] Tests & Build Functionality added by the pull request is covered by tests `mvn clean verify` has been executed successfully locally or a Travis build has passed You can merge this pull request into a Git repository by running: $ git pull https://github.com/huafengw/flink fix6492 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3898.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3898 commit 3a2e981efd5fffd25d551331af5b422a0812e802 Author: huafengw <fvunicorn@gmail.com> Date: 2017-05-15T07:56:19Z FLINK-6492 Fix unclosed DataOutputViewStream usage
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user huafengw commented on the issue:

          https://github.com/apache/flink/pull/3898

          Can anyone take a look at this one?

          Show
          githubbot ASF GitHub Bot added a comment - Github user huafengw commented on the issue: https://github.com/apache/flink/pull/3898 Can anyone take a look at this one?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user huafengw commented on the issue:

          https://github.com/apache/flink/pull/3898

          Hi @tzulitai, I'm new to Flink and would you mind taking a look at this one?

          Show
          githubbot ASF GitHub Bot added a comment - Github user huafengw commented on the issue: https://github.com/apache/flink/pull/3898 Hi @tzulitai, I'm new to Flink and would you mind taking a look at this one?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user tzulitai commented on the issue:

          https://github.com/apache/flink/pull/3898

          Hi @huafengw, thanks for the fixes! I'll probably merge this along with #3937 as there are some overlapping changes here and there.

          Show
          githubbot ASF GitHub Bot added a comment - Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/3898 Hi @huafengw, thanks for the fixes! I'll probably merge this along with #3937 as there are some overlapping changes here and there.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user gallenvara commented on the issue:

          https://github.com/apache/flink/pull/3898

          Hi, @huafengw . Welcome to Flink family. Thanks for your PR and the changes look good to me.

          Show
          githubbot ASF GitHub Bot added a comment - Github user gallenvara commented on the issue: https://github.com/apache/flink/pull/3898 Hi, @huafengw . Welcome to Flink family. Thanks for your PR and the changes look good to me.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user huafengw commented on the issue:

          https://github.com/apache/flink/pull/3898

          Thank you guys

          Show
          githubbot ASF GitHub Bot added a comment - Github user huafengw commented on the issue: https://github.com/apache/flink/pull/3898 Thank you guys
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user zhangminglei commented on the issue:

          https://github.com/apache/flink/pull/3898

          Hi, @huafengw Welcome also.

          Show
          githubbot ASF GitHub Bot added a comment - Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/3898 Hi, @huafengw Welcome also.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user zentol commented on the issue:

          https://github.com/apache/flink/pull/3898

          @tzulitai Did you forget about this PR?

          Show
          githubbot ASF GitHub Bot added a comment - Github user zentol commented on the issue: https://github.com/apache/flink/pull/3898 @tzulitai Did you forget about this PR?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user tzulitai commented on the issue:

          https://github.com/apache/flink/pull/3898

          ah ... yes indeed, thanks for reminding me. I'll merge this to master and 1.3; it should be ok if it ends up missing in the 1.3.0 release.

          Show
          githubbot ASF GitHub Bot added a comment - Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/3898 ah ... yes indeed, thanks for reminding me. I'll merge this to master and 1.3; it should be ok if it ends up missing in the 1.3.0 release.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/3898

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3898
          Hide
          tzulitai Tzu-Li (Gordon) Tai added a comment -

          Fixed for master with ded464b8bd60d8f19221c0f1589346684c11c78d.
          Fixed for release-1.3 with 0ae98d3863fb49f67ea4afdf66790b74c1d64d3d.

          Show
          tzulitai Tzu-Li (Gordon) Tai added a comment - Fixed for master with ded464b8bd60d8f19221c0f1589346684c11c78d. Fixed for release-1.3 with 0ae98d3863fb49f67ea4afdf66790b74c1d64d3d.

            People

            • Assignee:
              Unassigned
              Reporter:
              yuzhihong@gmail.com Ted Yu
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development