Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-6486

Pass RowTypeInfo to CodeGenerator instead of CRowTypeInfo

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: 1.3.0, 1.4.0
    • Component/s: Table API & SQL
    • Labels:
      None

      Description

      For now CodeGenerator only processes Row type, so we should pass RowTypeInfo to CodeGenerator instead of CRowTypeInfo. We can find these bugs in DataStreamGroupAggregate, DataStreamGroupWindowAggregate and DataStreamOverAggregate. These bugs will bring no error to the current flink because no code will make use of the error input type, however we should correct it.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user hequn8128 opened a pull request:

          https://github.com/apache/flink/pull/3850

          FLINK-6486 [table] (bugfix) Pass RowTypeInfo to CodeGenerator instead of CRowTypeInfo

          For now CodeGenerator only processes Row type, so we should pass RowTypeInfo to CodeGenerator instead of CRowTypeInfo. We can find these bugs in DataStreamGroupAggregate, DataStreamGroupWindowAggregate and DataStreamOverAggregate. These bugs will bring no error to the current flink because no code will make use of the error input type, however we should correct it.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/hequn8128/flink bugfix

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/3850.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #3850


          commit 75d668eb157e0ed90132976dcc96c167176810d1
          Author: Hequn Cheng <chenghequn@gmail.com>
          Date: 2017-05-08T12:55:51Z

          FLINK-6486 [table] (bugfix) Pass RowTypeInfo to CodeGenerator instead of CRowTypeInfo


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user hequn8128 opened a pull request: https://github.com/apache/flink/pull/3850 FLINK-6486 [table] (bugfix) Pass RowTypeInfo to CodeGenerator instead of CRowTypeInfo For now CodeGenerator only processes Row type, so we should pass RowTypeInfo to CodeGenerator instead of CRowTypeInfo. We can find these bugs in DataStreamGroupAggregate, DataStreamGroupWindowAggregate and DataStreamOverAggregate. These bugs will bring no error to the current flink because no code will make use of the error input type, however we should correct it. You can merge this pull request into a Git repository by running: $ git pull https://github.com/hequn8128/flink bugfix Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3850.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3850 commit 75d668eb157e0ed90132976dcc96c167176810d1 Author: Hequn Cheng <chenghequn@gmail.com> Date: 2017-05-08T12:55:51Z FLINK-6486 [table] (bugfix) Pass RowTypeInfo to CodeGenerator instead of CRowTypeInfo
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user fhueske commented on the issue:

          https://github.com/apache/flink/pull/3850

          +1 to merge

          Show
          githubbot ASF GitHub Bot added a comment - Github user fhueske commented on the issue: https://github.com/apache/flink/pull/3850 +1 to merge
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/3850

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3850
          Hide
          fhueske Fabian Hueske added a comment -

          Done for 1.3 dd799c746cc464550222b9b126e3f60c5259df9f
          Done for 1.4 b5ddbe5c360003b210a1212e54e6c50b8af538fa

          Show
          fhueske Fabian Hueske added a comment - Done for 1.3 dd799c746cc464550222b9b126e3f60c5259df9f Done for 1.4 b5ddbe5c360003b210a1212e54e6c50b8af538fa

            People

            • Assignee:
              hequn8128 Hequn Cheng
              Reporter:
              hequn8128 Hequn Cheng
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development