Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.3.0
    • Fix Version/s: 1.3.0
    • Component/s: Table API & SQL
    • Labels:
      None

      Description

      Currently, The window clause use case looks like as following:

      tab //Table('a,'b,'c)
         .window( Slide over 10.milli every 5.milli  as 'w) 
         .groupBy('w,'a,'b) 
         .select('a, 'b, 'c.sum, 'w.start, 'w.end)
      

      As we see the alias of window is essential. But the current implementation of the TableAPI does not have the constraint for the alias,So we must refactoring the API definition using TYPE SYSTEM lead to constraint for the alias.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user sunjincheng121 opened a pull request:

          https://github.com/apache/flink/pull/3786

          FLINK-6392[table] Change the alias of Window from optional to essen…

          In this PR refactoring the API definition using TYPE SYSTEM lead to constraint for the alias.

          • [x] General
          • The pull request references the related JIRA issue ("FLINK-6392[table] Change the alias of Window from optional to essential.")
          • The pull request addresses only one issue
          • Each commit in the PR has a meaningful commit message (including the JIRA id)
          • [ ] Documentation
          • Documentation has been added for new functionality
          • Old documentation affected by the pull request has been updated
          • JavaDoc for public methods has been added
          • [x] Tests & Build
          • Functionality added by the pull request is covered by tests
          • `mvn clean verify` has been executed successfully locally or a Travis build has passed

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/sunjincheng121/flink FLINK-6392-PR

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/3786.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #3786


          commit a9a2c0e8473da287cb5f77ba48ed9d5048e6a3a7
          Author: sunjincheng121 <sunjincheng121@gmail.com>
          Date: 2017-04-27T01:58:18Z

          FLINK-6392[table] Change the alias of Window from optional to essential.


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user sunjincheng121 opened a pull request: https://github.com/apache/flink/pull/3786 FLINK-6392 [table] Change the alias of Window from optional to essen… In this PR refactoring the API definition using TYPE SYSTEM lead to constraint for the alias. [x] General The pull request references the related JIRA issue (" FLINK-6392 [table] Change the alias of Window from optional to essential.") The pull request addresses only one issue Each commit in the PR has a meaningful commit message (including the JIRA id) [ ] Documentation Documentation has been added for new functionality Old documentation affected by the pull request has been updated JavaDoc for public methods has been added [x] Tests & Build Functionality added by the pull request is covered by tests `mvn clean verify` has been executed successfully locally or a Travis build has passed You can merge this pull request into a Git repository by running: $ git pull https://github.com/sunjincheng121/flink FLINK-6392 -PR Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3786.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3786 commit a9a2c0e8473da287cb5f77ba48ed9d5048e6a3a7 Author: sunjincheng121 <sunjincheng121@gmail.com> Date: 2017-04-27T01:58:18Z FLINK-6392 [table] Change the alias of Window from optional to essential.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user fhueske commented on the issue:

          https://github.com/apache/flink/pull/3786

          Thanks for the PR @sunjincheng121 and all refactoring!
          Will change some class names and merge it.

          Show
          githubbot ASF GitHub Bot added a comment - Github user fhueske commented on the issue: https://github.com/apache/flink/pull/3786 Thanks for the PR @sunjincheng121 and all refactoring! Will change some class names and merge it.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/3786

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3786
          Hide
          fhueske Fabian Hueske added a comment -

          Fixed for 1.3 with bb972b85a76d9b98ca5e90033e448f68f9109485

          Show
          fhueske Fabian Hueske added a comment - Fixed for 1.3 with bb972b85a76d9b98ca5e90033e448f68f9109485

            People

            • Assignee:
              sunjincheng121 sunjincheng
              Reporter:
              sunjincheng121 sunjincheng
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development