Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-6299

make all IT cases extend from TestLogger

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.3.0
    • Fix Version/s: 1.3.0
    • Component/s: Tests
    • Labels:
      None

      Description

      Not all of the integration tests extend from TestLogger but this is a very helpful tool so the currently running tests are written to the logs as well as their failures, especially for those tests where errors are often burried in the logs.

        Issue Links

          Activity

          Hide
          Zentol Chesnay Schepler added a comment -

          1.3: 06db242ea12936fd62d243a1778bb32ca98e9232

          Show
          Zentol Chesnay Schepler added a comment - 1.3: 06db242ea12936fd62d243a1778bb32ca98e9232
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/3713

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3713
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user zentol commented on the issue:

          https://github.com/apache/flink/pull/3713

          merging.

          Show
          githubbot ASF GitHub Bot added a comment - Github user zentol commented on the issue: https://github.com/apache/flink/pull/3713 merging.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user NicoK commented on the issue:

          https://github.com/apache/flink/pull/3713

          actually, the error was in the flink-hbase `pom.xml` - please let me include these hotfixes here as well which fix the actual error and prevent future errors.

          Show
          githubbot ASF GitHub Bot added a comment - Github user NicoK commented on the issue: https://github.com/apache/flink/pull/3713 actually, the error was in the flink-hbase `pom.xml` - please let me include these hotfixes here as well which fix the actual error and prevent future errors.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user NicoK commented on the issue:

          https://github.com/apache/flink/pull/3713

          Strangely, this does not yet provide logging for all test cases. After also applying #3708, `HBaseConnectorITCase`, for example does show up in the `flink-fast-tests-a` standard output but neither in `1.log` nor `2.log`...
          let me test this further

          Show
          githubbot ASF GitHub Bot added a comment - Github user NicoK commented on the issue: https://github.com/apache/flink/pull/3713 Strangely, this does not yet provide logging for all test cases. After also applying #3708, `HBaseConnectorITCase`, for example does show up in the `flink-fast-tests-a` standard output but neither in `1.log` nor `2.log`... let me test this further
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user zentol commented on the issue:

          https://github.com/apache/flink/pull/3713

          Looks good, +1 to merge.

          Show
          githubbot ASF GitHub Bot added a comment - Github user zentol commented on the issue: https://github.com/apache/flink/pull/3713 Looks good, +1 to merge.
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user NicoK opened a pull request:

          https://github.com/apache/flink/pull/3713

          FLINK-6299 make all IT cases extend from TestLogger

          This way, currently executed tests and their failures are properly logged.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/NicoK/flink flink-6299

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/3713.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #3713


          commit 84cce5ddfb2f90fb6696bad94a7f74a0c46e10c6
          Author: Nico Kruber <nico@data-artisans.com>
          Date: 2017-04-12T09:09:03Z

          FLINK-6299 make all IT cases extend from TestLogger

          This way, currently executed tests and their failures are properly logged.


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user NicoK opened a pull request: https://github.com/apache/flink/pull/3713 FLINK-6299 make all IT cases extend from TestLogger This way, currently executed tests and their failures are properly logged. You can merge this pull request into a Git repository by running: $ git pull https://github.com/NicoK/flink flink-6299 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3713.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3713 commit 84cce5ddfb2f90fb6696bad94a7f74a0c46e10c6 Author: Nico Kruber <nico@data-artisans.com> Date: 2017-04-12T09:09:03Z FLINK-6299 make all IT cases extend from TestLogger This way, currently executed tests and their failures are properly logged.

            People

            • Assignee:
              NicoK Nico Kruber
              Reporter:
              NicoK Nico Kruber
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development