Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.3.0
    • Fix Version/s: 1.3.0
    • Labels:
      None

      Description

      In order to make the standalone mode work, we have to be able to assign names to the RpcEndpoints. In the case of the Akka implementation they would correspond to the actor names. This information is necessary to look the corresponding endpoints up on a remote host because in standalone mode the names have to be deterministic.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user tillrohrmann opened a pull request:

          https://github.com/apache/flink/pull/3596

          FLINK-6155 Introduce an endpoint id for RpcEndpoints

          An endpoint id allows to assign a unique name to a `RpcEndpoint`. This name can be used
          to look up the rpc endpoint within the RpcService. In the case of the `AkkaRpcService` implementation, it corresponds to the actor name used for the `AkkaRpcActor`.

          Remove component endpoint name methods from the `HighAvailabilityServices`.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/tillrohrmann/flink addRpcActorName

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/3596.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #3596


          commit c97a3f8f9796e5e1d25eae9d3a58666ded98d3d7
          Author: Till Rohrmann <trohrmann@apache.org>
          Date: 2017-03-22T08:09:02Z

          FLINK-6155 Introduce an endpoint id for RpcEndpoints

          An endpoint id allows to assign a unique name to a RpcEndpoint. This name can be used
          to look up the rpc endpoint within the RpcService.

          Remove component endpoint name methods from the HighAvailabilityServices


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/3596 FLINK-6155 Introduce an endpoint id for RpcEndpoints An endpoint id allows to assign a unique name to a `RpcEndpoint`. This name can be used to look up the rpc endpoint within the RpcService. In the case of the `AkkaRpcService` implementation, it corresponds to the actor name used for the `AkkaRpcActor`. Remove component endpoint name methods from the `HighAvailabilityServices`. You can merge this pull request into a Git repository by running: $ git pull https://github.com/tillrohrmann/flink addRpcActorName Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3596.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3596 commit c97a3f8f9796e5e1d25eae9d3a58666ded98d3d7 Author: Till Rohrmann <trohrmann@apache.org> Date: 2017-03-22T08:09:02Z FLINK-6155 Introduce an endpoint id for RpcEndpoints An endpoint id allows to assign a unique name to a RpcEndpoint. This name can be used to look up the rpc endpoint within the RpcService. Remove component endpoint name methods from the HighAvailabilityServices
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user tillrohrmann commented on the issue:

          https://github.com/apache/flink/pull/3596

          Rebasing on the latest master.

          Show
          githubbot ASF GitHub Bot added a comment - Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/3596 Rebasing on the latest master.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user tillrohrmann commented on the issue:

          https://github.com/apache/flink/pull/3596

          Travis passed. Rebasing on the latest master. If travis passes again, then I will merge this PR.

          Show
          githubbot ASF GitHub Bot added a comment - Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/3596 Travis passed. Rebasing on the latest master. If travis passes again, then I will merge this PR.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user StephanEwen commented on the issue:

          https://github.com/apache/flink/pull/3596

          Good changes!

          I think we could actually drop the explicit endpoint name from the `TaskExecutor` and always let it use a random name (as is the default when no explicit name is given). That would simplify the code a bit and it should work since the connection is always established by the `TaskExecutor` towards the `ResourceManager` and `JobManager`, but never the the other way around.

          Show
          githubbot ASF GitHub Bot added a comment - Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3596 Good changes! I think we could actually drop the explicit endpoint name from the `TaskExecutor` and always let it use a random name (as is the default when no explicit name is given). That would simplify the code a bit and it should work since the connection is always established by the `TaskExecutor` towards the `ResourceManager` and `JobManager`, but never the the other way around.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user tillrohrmann commented on the issue:

          https://github.com/apache/flink/pull/3596

          Thanks for the review @StephanEwen. You're right that it should not be necessary to assign a name to the `TaskExecutor` and the `ResourceManager`. Will change it so that these components assign a random name.

          Will then rebase the PR and once Travis gives green light, I will merge it.

          Show
          githubbot ASF GitHub Bot added a comment - Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/3596 Thanks for the review @StephanEwen. You're right that it should not be necessary to assign a name to the `TaskExecutor` and the `ResourceManager`. Will change it so that these components assign a random name. Will then rebase the PR and once Travis gives green light, I will merge it.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user tillrohrmann commented on the issue:

          https://github.com/apache/flink/pull/3596

          I think I have to correct myself. In the general case, there might be the need to connect from the dispatcher component to `ResourceManager`. If the `ResourceManager` runs in a different process in standalone mode, then we have to be able to configure a fixed endpoint name, I think.

          Show
          githubbot ASF GitHub Bot added a comment - Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/3596 I think I have to correct myself. In the general case, there might be the need to connect from the dispatcher component to `ResourceManager`. If the `ResourceManager` runs in a different process in standalone mode, then we have to be able to configure a fixed endpoint name, I think.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user tillrohrmann commented on the issue:

          https://github.com/apache/flink/pull/3596

          Failing test case has just been fixed. Merging this PR.

          Show
          githubbot ASF GitHub Bot added a comment - Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/3596 Failing test case has just been fixed. Merging this PR.
          Hide
          till.rohrmann Till Rohrmann added a comment -

          Fixed via 433a345edccdee29385957841e6513679690a5e9

          Show
          till.rohrmann Till Rohrmann added a comment - Fixed via 433a345edccdee29385957841e6513679690a5e9
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/3596

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3596

            People

            • Assignee:
              till.rohrmann Till Rohrmann
              Reporter:
              till.rohrmann Till Rohrmann
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development