Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-6112

Support Calcite 1.12's new numerical functions

    Details

    • Type: New Feature
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.3.0
    • Component/s: Table API & SQL
    • Labels:
      None

      Description

      CALCITE-1557 introduces the support of some missing numerical functions.

      We should add the functions.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/3718

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3718
          Hide
          twalthr Timo Walther added a comment -

          Fixed in 1.3.0: a06b3222bb97150f643c22fe1a1054e3239c1c2d

          Show
          twalthr Timo Walther added a comment - Fixed in 1.3.0: a06b3222bb97150f643c22fe1a1054e3239c1c2d
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user twalthr commented on the issue:

          https://github.com/apache/flink/pull/3718

          Merging...

          Show
          githubbot ASF GitHub Bot added a comment - Github user twalthr commented on the issue: https://github.com/apache/flink/pull/3718 Merging...
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user twalthr commented on the issue:

          https://github.com/apache/flink/pull/3718

          Thanks for the PR @mtunique. I quickly looked through the changes, it looks very good. I will review it in the next days, I think we can include it in the 1.3 release.

          Show
          githubbot ASF GitHub Bot added a comment - Github user twalthr commented on the issue: https://github.com/apache/flink/pull/3718 Thanks for the PR @mtunique. I quickly looked through the changes, it looks very good. I will review it in the next days, I think we can include it in the 1.3 release.
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user mtunique opened a pull request:

          https://github.com/apache/flink/pull/3718

          FLINK-6112 Support Calcite 1.12's new numerical functions

          Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
          If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
          In addition to going through the list, please provide a meaningful description of your changes.

          • [x] General
          • The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
          • The pull request addresses only one issue
          • Each commit in the PR has a meaningful commit message (including the JIRA id)
          • [x] Documentation
          • Documentation has been added for new functionality
          • Old documentation affected by the pull request has been updated
          • JavaDoc for public methods has been added
          • [x] Tests & Build
          • Functionality added by the pull request is covered by tests
          • `mvn clean verify` has been executed successfully locally or a Travis build has passed

          Because the function `asin` conflicts with the keyword `as`, I add keyword `ASIN` in `ExpressionParser.scala`.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/mtunique/flink FLINK-6112

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/3718.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #3718


          commit 42ddcb3cf59f2c23e12dfb74b6596dd9a19dddb2
          Author: mtunique <oatgnem@gmail.com>
          Date: 2017-04-07T10:04:03Z

          add sin function

          commit 8c4c08215446264eaa0439a8d771ff895e92943e
          Author: mtunique <oatgnem@gmail.com>
          Date: 2017-04-11T14:08:03Z

          add some builtin function


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user mtunique opened a pull request: https://github.com/apache/flink/pull/3718 FLINK-6112 Support Calcite 1.12's new numerical functions Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration. If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide] ( http://flink.apache.org/how-to-contribute.html ). In addition to going through the list, please provide a meaningful description of your changes. [x] General The pull request references the related JIRA issue (" [FLINK-XXX] Jira title text") The pull request addresses only one issue Each commit in the PR has a meaningful commit message (including the JIRA id) [x] Documentation Documentation has been added for new functionality Old documentation affected by the pull request has been updated JavaDoc for public methods has been added [x] Tests & Build Functionality added by the pull request is covered by tests `mvn clean verify` has been executed successfully locally or a Travis build has passed Because the function `asin` conflicts with the keyword `as`, I add keyword `ASIN` in `ExpressionParser.scala`. You can merge this pull request into a Git repository by running: $ git pull https://github.com/mtunique/flink FLINK-6112 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3718.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3718 commit 42ddcb3cf59f2c23e12dfb74b6596dd9a19dddb2 Author: mtunique <oatgnem@gmail.com> Date: 2017-04-07T10:04:03Z add sin function commit 8c4c08215446264eaa0439a8d771ff895e92943e Author: mtunique <oatgnem@gmail.com> Date: 2017-04-11T14:08:03Z add some builtin function
          Hide
          twalthr Timo Walther added a comment -

          Tao Meng We bumped up the Calcite version. We can now implement this issue.

          Show
          twalthr Timo Walther added a comment - Tao Meng We bumped up the Calcite version. We can now implement this issue.

            People

            • Assignee:
              mtunqiue Tao Meng
              Reporter:
              mtunqiue Tao Meng
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development