Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-6084

Cassandra connector does not declare all dependencies

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 1.2.0
    • Fix Version/s: 1.3.0, 1.2.1
    • Component/s: Cassandra Connector
    • Labels:
      None

      Description

      This has been reported by a user: http://apache-flink-user-mailing-list-archive.2336050.n4.nabble.com/Flink-1-2-and-Cassandra-Connector-td11546.html

      The cassandra client defines metrics-core as a dependency, but the shading is dropping the dependency when building the dependency reduced pom.
      To resolve the issue, we need to add the following line into the shading config of the cassandra module:

      <promoteTransitiveDependencies>true</promoteTransitiveDependencies>

      This makes the metrics dependency appear again in the dep red pom.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user rmetzger opened a pull request:

          https://github.com/apache/flink/pull/3556

          FLINK-6084[Cassandra] Promote transitive dependencies

          See JIRA for details.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/rmetzger/flink flink6084

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/3556.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #3556


          commit 2ff62dec9127a039e3f646489aec9177f46ae824
          Author: Robert Metzger <rmetzger@apache.org>
          Date: 2017-03-16T17:11:32Z

          FLINK-6084[Cassandra] Promote transitive dependencies


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user rmetzger opened a pull request: https://github.com/apache/flink/pull/3556 FLINK-6084 [Cassandra] Promote transitive dependencies See JIRA for details. You can merge this pull request into a Git repository by running: $ git pull https://github.com/rmetzger/flink flink6084 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3556.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3556 commit 2ff62dec9127a039e3f646489aec9177f46ae824 Author: Robert Metzger <rmetzger@apache.org> Date: 2017-03-16T17:11:32Z FLINK-6084 [Cassandra] Promote transitive dependencies
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user StephanEwen commented on the issue:

          https://github.com/apache/flink/pull/3556

          Looks good to me, +1 to merge for both `master` and `release-1.2`

          Show
          githubbot ASF GitHub Bot added a comment - Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3556 Looks good to me, +1 to merge for both `master` and `release-1.2`
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user tzulitai commented on the issue:

          https://github.com/apache/flink/pull/3556

          Thanks for the fix, LGTM.
          @rmetzger could you proceed to merge this?

          Show
          githubbot ASF GitHub Bot added a comment - Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/3556 Thanks for the fix, LGTM. @rmetzger could you proceed to merge this?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user rmetzger commented on the issue:

          https://github.com/apache/flink/pull/3556

          I'll merge it later today.

          Show
          githubbot ASF GitHub Bot added a comment - Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/3556 I'll merge it later today.
          Show
          rmetzger Robert Metzger added a comment - Resolved for 1.3 in http://git-wip-us.apache.org/repos/asf/flink/commit/0236992e Resolved for 1.2.1 in http://git-wip-us.apache.org/repos/asf/flink/commit/ffd146a6
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/3556

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3556

            People

            • Assignee:
              rmetzger Robert Metzger
              Reporter:
              rmetzger Robert Metzger
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development