Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-6051

Wrong metric scope names in documentation

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.2.0, 1.3.0
    • Fix Version/s: 1.3.0, 1.2.1
    • Component/s: Documentation, Metrics
    • Labels:
      None

      Description

      FLINK-4402 fixed the following metrics names:
      metrics.scope.tm.task → metrics.scope.task
      metrics.scope.tm.operator → metrics.scope.operator

      However, the 1.2.0 documentation lists the incorrect metric names again.

      As a side note, it would be convenient to have all of the configuration options documented in a machine readable format. To build docker images I process the config file with sed to extract the options and turn them into env vars, which is how I noticed this issue.

        Issue Links

          Activity

          Hide
          Zentol Chesnay Schepler added a comment -

          1.2: 9206df666057eb32f82c93f537a04466c67b9fc4
          1.3: 609b2577a6490dbfa5eb48fb03fd1c0f93c6c0da

          Show
          Zentol Chesnay Schepler added a comment - 1.2: 9206df666057eb32f82c93f537a04466c67b9fc4 1.3: 609b2577a6490dbfa5eb48fb03fd1c0f93c6c0da
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/3538

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3538
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user zentol commented on the issue:

          https://github.com/apache/flink/pull/3538

          merging this.

          Show
          githubbot ASF GitHub Bot added a comment - Github user zentol commented on the issue: https://github.com/apache/flink/pull/3538 merging this.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user zentol commented on the issue:

          https://github.com/apache/flink/pull/3538

          +1 to merge for 1.2 and 1.3.

          Show
          githubbot ASF GitHub Bot added a comment - Github user zentol commented on the issue: https://github.com/apache/flink/pull/3538 +1 to merge for 1.2 and 1.3.
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user hadronzoo opened a pull request:

          https://github.com/apache/flink/pull/3538

          FLINK-6051: Correct metrics scope names

          Closes FLINK-6051.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/orgsync/flink FLINK-6051

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/3538.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #3538


          commit ab4332801428e14b8077a2a7669a51f8a1607ca3
          Author: Joshua Griffith <jgriffith@campuslabs.com>
          Date: 2017-03-14T17:10:12Z

          Correct metrics scope names

          Closes FLINK-6051.


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user hadronzoo opened a pull request: https://github.com/apache/flink/pull/3538 FLINK-6051 : Correct metrics scope names Closes FLINK-6051 . You can merge this pull request into a Git repository by running: $ git pull https://github.com/orgsync/flink FLINK-6051 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3538.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3538 commit ab4332801428e14b8077a2a7669a51f8a1607ca3 Author: Joshua Griffith <jgriffith@campuslabs.com> Date: 2017-03-14T17:10:12Z Correct metrics scope names Closes FLINK-6051 .

            People

            • Assignee:
              Unassigned
              Reporter:
              hadronzoo Joshua Griffith
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development