Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-5945

Close function in OuterJoinOperatorBase#executeOnCollections

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.2.0, 1.1.4, 1.3.0
    • Fix Version/s: 1.3.0, 1.1.5, 1.2.1
    • Component/s: Core
    • Labels:
      None

      Description

      OuterJoinOperatorBase#executeOnCollections does not call FunctionUtils.closeFunction(function);. I am seeing this affect the Gelly test for the HITS algorithm when using a convergence threshold rather than a fixed number of iterations.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user greghogan opened a pull request:

          https://github.com/apache/flink/pull/3453

          FLINK-5945 [core] Close function in OuterJoinOperatorBase#executeOnCollections

          Conclude OuterJoinOperatorBase#executeOnCollections with a call to FunctionUtils.closeFunction(function) in order to close rich user functions.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/greghogan/flink 5945_close_function_in_OuterJoinOperatorBase#executeOnCollections

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/3453.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #3453


          commit 933260bb35ac959880d2d22ffb1035f4c96590b4
          Author: Greg Hogan <code@greghogan.com>
          Date: 2017-03-01T20:55:48Z

          FLINK-5945 [core] Close function in OuterJoinOperatorBase#executeOnCollections

          Conclude OuterJoinOperatorBase#executeOnCollections with a call to
          FunctionUtils.closeFunction(function) in order to close rich user
          functions.


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user greghogan opened a pull request: https://github.com/apache/flink/pull/3453 FLINK-5945 [core] Close function in OuterJoinOperatorBase#executeOnCollections Conclude OuterJoinOperatorBase#executeOnCollections with a call to FunctionUtils.closeFunction(function) in order to close rich user functions. You can merge this pull request into a Git repository by running: $ git pull https://github.com/greghogan/flink 5945_close_function_in_OuterJoinOperatorBase#executeOnCollections Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3453.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3453 commit 933260bb35ac959880d2d22ffb1035f4c96590b4 Author: Greg Hogan <code@greghogan.com> Date: 2017-03-01T20:55:48Z FLINK-5945 [core] Close function in OuterJoinOperatorBase#executeOnCollections Conclude OuterJoinOperatorBase#executeOnCollections with a call to FunctionUtils.closeFunction(function) in order to close rich user functions.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user fhueske commented on the issue:

          https://github.com/apache/flink/pull/3453

          Looks good to me.
          +1 to merge

          Show
          githubbot ASF GitHub Bot added a comment - Github user fhueske commented on the issue: https://github.com/apache/flink/pull/3453 Looks good to me. +1 to merge
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user greghogan commented on the issue:

          https://github.com/apache/flink/pull/3453

          @fhueske thanks for the review. The bug was affecting a test in `HITSTest` for which I have added the simple fix since I am improving the tests in FLINK-4896.

          Will merge after verification passes.

          Show
          githubbot ASF GitHub Bot added a comment - Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3453 @fhueske thanks for the review. The bug was affecting a test in `HITSTest` for which I have added the simple fix since I am improving the tests in FLINK-4896 . Will merge after verification passes.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/3453

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3453
          Hide
          greghogan Greg Hogan added a comment -

          1.3.0: 243ef69bf5233998dd7f849721cfcb83669b663c
          1.2.1: 54a02d9a4b81aeb462f958bdeda0aaa509357677
          1.1.5: 01703e60e0b583d6d32c2cba395f6199c5773c5e

          Show
          greghogan Greg Hogan added a comment - 1.3.0: 243ef69bf5233998dd7f849721cfcb83669b663c 1.2.1: 54a02d9a4b81aeb462f958bdeda0aaa509357677 1.1.5: 01703e60e0b583d6d32c2cba395f6199c5773c5e

            People

            • Assignee:
              greghogan Greg Hogan
              Reporter:
              greghogan Greg Hogan
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development