Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-5938

Replace ExecutionContext by Executor in Scheduler

        Details

        • Type: Improvement
        • Status: Closed
        • Priority: Minor
        • Resolution: Fixed
        • Affects Version/s: 1.2.0, 1.3.0
        • Fix Version/s: 1.3.0, 1.2.1
        • Component/s: Distributed Coordination
        • Labels:
          None

          Description

          The Scheduler uses internally a Scala ExecutionContext and Akka's Futures to execute concurrent tasks. In order to remove the dependency on both frameworks, we should replace it via an Executor.

            Issue Links

            links to

            Web Link GitHub Pull Request #3435

            Web Link GitHub Pull Request #3436

            Web Link GitHub Pull Request #3439

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              githubbot ASF GitHub Bot added a comment -

              GitHub user tillrohrmann opened a pull request:

              https://github.com/apache/flink/pull/3435

              FLINK-5938 Replace ExecutionContext by Executor in Scheduler

              In order to remove the Scheduler's dependency on Scala's ExecutionContext and
              Akka's futures, this PR replaces the ExecutionContext by an Executor which is
              used to execute the concurrent handleNewSlot call.

              You can merge this pull request into a Git repository by running:

              $ git pull https://github.com/tillrohrmann/flink removeExecutionContextFromSchedulerMaster

              Alternatively you can review and apply these changes as the patch at:

              https://github.com/apache/flink/pull/3435.patch

              To close this pull request, make a commit to your master/trunk branch
              with (at least) the following in the commit message:

              This closes #3435

              commit 5858c8dc79546ccde68b99993a2695216452bacc
              Author: Till Rohrmann <trohrmann@apache.org>
              Date: 2017-02-28T16:27:03Z

              FLINK-5938 Replace ExecutionContext by Executor in Scheduler

              In order to remove the Scheduler's dependency on Scala's ExecutionContext and
              Akka's futures, this PR replaces the ExecutionContext by an Executor which is
              used to execute the concurrent handleNewSlot call.

              Show
              githubbot ASF GitHub Bot added a comment - GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/3435 FLINK-5938 Replace ExecutionContext by Executor in Scheduler In order to remove the Scheduler's dependency on Scala's ExecutionContext and Akka's futures, this PR replaces the ExecutionContext by an Executor which is used to execute the concurrent handleNewSlot call. You can merge this pull request into a Git repository by running: $ git pull https://github.com/tillrohrmann/flink removeExecutionContextFromSchedulerMaster Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3435.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3435 commit 5858c8dc79546ccde68b99993a2695216452bacc Author: Till Rohrmann <trohrmann@apache.org> Date: 2017-02-28T16:27:03Z FLINK-5938 Replace ExecutionContext by Executor in Scheduler In order to remove the Scheduler's dependency on Scala's ExecutionContext and Akka's futures, this PR replaces the ExecutionContext by an Executor which is used to execute the concurrent handleNewSlot call.
              Hide
              Permalink
              githubbot ASF GitHub Bot added a comment -

              GitHub user tillrohrmann opened a pull request:

              https://github.com/apache/flink/pull/3436

              [backport-1.2] FLINK-5938 Replace ExecutionContext by Executor in Scheduler

              Backport of #3435 onto `release-1.2`

              In order to remove the Scheduler's dependency on Scala's ExecutionContext and
              Akka's futures, this PR replaces the ExecutionContext by an Executor which is
              used to execute the concurrent handleNewSlot call.

              You can merge this pull request into a Git repository by running:

              $ git pull https://github.com/tillrohrmann/flink removeExecutionContextFromSchedulerBp1.2

              Alternatively you can review and apply these changes as the patch at:

              https://github.com/apache/flink/pull/3436.patch

              To close this pull request, make a commit to your master/trunk branch
              with (at least) the following in the commit message:

              This closes #3436

              commit b00043a73683bf67d32c6cf3f7360fd9fe5e064a
              Author: Till Rohrmann <trohrmann@apache.org>
              Date: 2017-02-28T16:27:03Z

              FLINK-5938 Replace ExecutionContext by Executor in Scheduler

              In order to remove the Scheduler's dependency on Scala's ExecutionContext and
              Akka's futures, this PR replaces the ExecutionContext by an Executor which is
              used to execute the concurrent handleNewSlot call.

              Show
              githubbot ASF GitHub Bot added a comment - GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/3436 [backport-1.2] FLINK-5938 Replace ExecutionContext by Executor in Scheduler Backport of #3435 onto `release-1.2` In order to remove the Scheduler's dependency on Scala's ExecutionContext and Akka's futures, this PR replaces the ExecutionContext by an Executor which is used to execute the concurrent handleNewSlot call. You can merge this pull request into a Git repository by running: $ git pull https://github.com/tillrohrmann/flink removeExecutionContextFromSchedulerBp1.2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3436.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3436 commit b00043a73683bf67d32c6cf3f7360fd9fe5e064a Author: Till Rohrmann <trohrmann@apache.org> Date: 2017-02-28T16:27:03Z FLINK-5938 Replace ExecutionContext by Executor in Scheduler In order to remove the Scheduler's dependency on Scala's ExecutionContext and Akka's futures, this PR replaces the ExecutionContext by an Executor which is used to execute the concurrent handleNewSlot call.
              Hide
              Permalink
              githubbot ASF GitHub Bot added a comment -

              Github user tillrohrmann closed the pull request at:

              https://github.com/apache/flink/pull/3436

              Show
              githubbot ASF GitHub Bot added a comment - Github user tillrohrmann closed the pull request at: https://github.com/apache/flink/pull/3436
              Hide
              Permalink
              githubbot ASF GitHub Bot added a comment -

              GitHub user tillrohrmann opened a pull request:

              https://github.com/apache/flink/pull/3439

              [backport-1.2] FLINK-5938 Replace ExecutionContext by Executor in Scheduler

              This is a backport of #3435.

              In order to remove the Scheduler's dependency on Scala's ExecutionContext and
              Akka's futures, this PR replaces the ExecutionContext by an Executor which is
              used to execute the concurrent handleNewSlot call.

              You can merge this pull request into a Git repository by running:

              $ git pull https://github.com/tillrohrmann/flink removeExecutionContextFromSchedulerBp1.2

              Alternatively you can review and apply these changes as the patch at:

              https://github.com/apache/flink/pull/3439.patch

              To close this pull request, make a commit to your master/trunk branch
              with (at least) the following in the commit message:

              This closes #3439

              commit 045e2187f6d43679115909b10aaeb78c627b758c
              Author: Till Rohrmann <trohrmann@apache.org>
              Date: 2017-02-28T16:27:03Z

              FLINK-5938 Replace ExecutionContext by Executor in Scheduler

              In order to remove the Scheduler's dependency on Scala's ExecutionContext and
              Akka's futures, this PR replaces the ExecutionContext by an Executor which is
              used to execute the concurrent handleNewSlot call.

              Show
              githubbot ASF GitHub Bot added a comment - GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/3439 [backport-1.2] FLINK-5938 Replace ExecutionContext by Executor in Scheduler This is a backport of #3435. In order to remove the Scheduler's dependency on Scala's ExecutionContext and Akka's futures, this PR replaces the ExecutionContext by an Executor which is used to execute the concurrent handleNewSlot call. You can merge this pull request into a Git repository by running: $ git pull https://github.com/tillrohrmann/flink removeExecutionContextFromSchedulerBp1.2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3439.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3439 commit 045e2187f6d43679115909b10aaeb78c627b758c Author: Till Rohrmann <trohrmann@apache.org> Date: 2017-02-28T16:27:03Z FLINK-5938 Replace ExecutionContext by Executor in Scheduler In order to remove the Scheduler's dependency on Scala's ExecutionContext and Akka's futures, this PR replaces the ExecutionContext by an Executor which is used to execute the concurrent handleNewSlot call.
              Hide
              Permalink
              githubbot ASF GitHub Bot added a comment -

              Github user StephanEwen commented on the issue:

              https://github.com/apache/flink/pull/3435

              Good change, +1

              Show
              githubbot ASF GitHub Bot added a comment - Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3435 Good change, +1
              Hide
              Permalink
              githubbot ASF GitHub Bot added a comment -

              Github user StephanEwen commented on the issue:

              https://github.com/apache/flink/pull/3439

              +1

              Show
              githubbot ASF GitHub Bot added a comment - Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3439 +1
              Hide
              Permalink
              githubbot ASF GitHub Bot added a comment -

              Github user tillrohrmann commented on the issue:

              https://github.com/apache/flink/pull/3435

              Thanks for the review @StephanEwen. Merging this PR.

              Show
              githubbot ASF GitHub Bot added a comment - Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/3435 Thanks for the review @StephanEwen. Merging this PR.
              Hide
              Permalink
              githubbot ASF GitHub Bot added a comment -

              Github user asfgit closed the pull request at:

              https://github.com/apache/flink/pull/3435

              Show
              githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3435
              Hide
              Permalink
              githubbot ASF GitHub Bot added a comment -

              Github user tillrohrmann commented on the issue:

              https://github.com/apache/flink/pull/3439

              Thanks for your review @StephanEwen. Merging this PR.

              Show
              githubbot ASF GitHub Bot added a comment - Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/3439 Thanks for your review @StephanEwen. Merging this PR.
              Hide
              Permalink
              till.rohrmann Till Rohrmann added a comment -

              1.3.0: cde3cdd00c7b97f86904f641475381240fc440df
              1.2.1: 53b454285c810b83232a1c97d945f16ab3634c68

              Show
              till.rohrmann Till Rohrmann added a comment - 1.3.0: cde3cdd00c7b97f86904f641475381240fc440df 1.2.1: 53b454285c810b83232a1c97d945f16ab3634c68
              Hide
              Permalink
              githubbot ASF GitHub Bot added a comment -

              Github user tillrohrmann closed the pull request at:

              https://github.com/apache/flink/pull/3439

              Show
              githubbot ASF GitHub Bot added a comment - Github user tillrohrmann closed the pull request at: https://github.com/apache/flink/pull/3439

                People

                • Assignee:
                  till.rohrmann Till Rohrmann
                  Reporter:
                  till.rohrmann Till Rohrmann
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Development