Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.3.0, 1.2.1
    • Component/s: Webfrontend, YARN
    • Labels:
      None

      Description

      In yarn mode, the web frontend url is accessed from yarn in format like "http://spark-91-206:8088/proxy/application_1487122678902_0015/", and the running job page's url is "http://spark-91-206:8088/proxy/application_1487122678902_0015/#/jobs/9440a129ea5899c16e7c1a7e8f2897b3".

      One .png file called "horizontal.png", which is very small can not be loaded in that mode, because in "index.styl" it is cited as absolute path.

      We should make the path relative.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user WangTaoTheTonic opened a pull request:

          https://github.com/apache/flink/pull/3337

          FLINK-5825[UI]make the cite path relative to show it correctly

          In yarn mode, the web frontend url is accessed from yarn in format like "http://spark-91-206:8088/proxy/application_1487122678902_0015/", and the running job page's url is "http://spark-91-206:8088/proxy/application_1487122678902_0015/#/jobs/9440a129ea5899c16e7c1a7e8f2897b3".
          One .png file called "horizontal.png", which is very small can not be loaded in that mode, because in "index.styl" it is cited as absolute path.
          We should make the path relative.

          • [ ] Tests & Build
            LATER I will paste difference between before and after.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/WangTaoTheTonic/flink FLINK-5825

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/3337.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #3337


          commit c2e2711b2f815a4aa1b9c8be2478c963c41da245
          Author: WangTaoTheTonic <wangtao111@huawei.com>
          Date: 2017-02-17T06:48:14Z

          make the cite path relative to show it correctly


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user WangTaoTheTonic opened a pull request: https://github.com/apache/flink/pull/3337 FLINK-5825 [UI] make the cite path relative to show it correctly In yarn mode, the web frontend url is accessed from yarn in format like "http://spark-91-206:8088/proxy/application_1487122678902_0015/", and the running job page's url is "http://spark-91-206:8088/proxy/application_1487122678902_0015/#/jobs/9440a129ea5899c16e7c1a7e8f2897b3". One .png file called "horizontal.png", which is very small can not be loaded in that mode, because in "index.styl" it is cited as absolute path. We should make the path relative. [ ] Tests & Build LATER I will paste difference between before and after. You can merge this pull request into a Git repository by running: $ git pull https://github.com/WangTaoTheTonic/flink FLINK-5825 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3337.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3337 commit c2e2711b2f815a4aa1b9c8be2478c963c41da245 Author: WangTaoTheTonic <wangtao111@huawei.com> Date: 2017-02-17T06:48:14Z make the cite path relative to show it correctly
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user uce commented on the issue:

          https://github.com/apache/flink/pull/3337

          Thanks for the pull request. Let me try this out and merge it if everything works as expected.

          Show
          githubbot ASF GitHub Bot added a comment - Github user uce commented on the issue: https://github.com/apache/flink/pull/3337 Thanks for the pull request. Let me try this out and merge it if everything works as expected.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/3337

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3337
          Hide
          uce Ufuk Celebi added a comment -

          Fixed in a2b0816 (master), 69d453b (release-1.2).

          Show
          uce Ufuk Celebi added a comment - Fixed in a2b0816 (master), 69d453b (release-1.2).

            People

            • Assignee:
              Unassigned
              Reporter:
              WangTao Tao Wang
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development