Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-5839 Flink Security problem collection
  3. FLINK-5723

Use "Used" instead of "Initial" to make taskmanager tag more readable

    Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.3.0, 1.2.1
    • Component/s: Webfrontend
    • Labels:
      None

      Description

      Now in JobManager web fronted, the used memory of task managers is presented as "Initial" in table header, which actually means "memory used", from codes.

      I'd like change it to be more readable, even it is trivial one.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user WangTaoTheTonic closed the pull request at:

          https://github.com/apache/flink/pull/3274

          Show
          githubbot ASF GitHub Bot added a comment - Github user WangTaoTheTonic closed the pull request at: https://github.com/apache/flink/pull/3274
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user WangTaoTheTonic commented on the issue:

          https://github.com/apache/flink/pull/3274

          sure.

          Fixed in

          • 1.2.1 via e3e3c2a7f9c8dd8576e0e27b2efddb7ff42c7c0d
          • 1.3.0 via 03e6c249156fbbfeef39397a70c70bb905469d09
          Show
          githubbot ASF GitHub Bot added a comment - Github user WangTaoTheTonic commented on the issue: https://github.com/apache/flink/pull/3274 sure. Fixed in 1.2.1 via e3e3c2a7f9c8dd8576e0e27b2efddb7ff42c7c0d 1.3.0 via 03e6c249156fbbfeef39397a70c70bb905469d09
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user uce commented on the issue:

          https://github.com/apache/flink/pull/3274

          @WangTaoTheTonic We forgot to close this PR while merging. Could you please close this manually?

          Show
          githubbot ASF GitHub Bot added a comment - Github user uce commented on the issue: https://github.com/apache/flink/pull/3274 @WangTaoTheTonic We forgot to close this PR while merging. Could you please close this manually?
          Hide
          StephanEwen Stephan Ewen added a comment -

          Fixed in

          • 1.2.1 via e3e3c2a7f9c8dd8576e0e27b2efddb7ff42c7c0d
          • 1.3.0 via 03e6c249156fbbfeef39397a70c70bb905469d09
          Show
          StephanEwen Stephan Ewen added a comment - Fixed in 1.2.1 via e3e3c2a7f9c8dd8576e0e27b2efddb7ff42c7c0d 1.3.0 via 03e6c249156fbbfeef39397a70c70bb905469d09
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user StephanEwen commented on the issue:

          https://github.com/apache/flink/pull/3274

          Looks good, merging this...

          Show
          githubbot ASF GitHub Bot added a comment - Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3274 Looks good, merging this...
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user WangTaoTheTonic commented on the issue:

          https://github.com/apache/flink/pull/3274

          @StephanEwen What do you think about this? Could you help merge this if you're ok with it? Thanks

          Show
          githubbot ASF GitHub Bot added a comment - Github user WangTaoTheTonic commented on the issue: https://github.com/apache/flink/pull/3274 @StephanEwen What do you think about this? Could you help merge this if you're ok with it? Thanks
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user zentol commented on the issue:

          https://github.com/apache/flink/pull/3274

          +1 from my side.

          Show
          githubbot ASF GitHub Bot added a comment - Github user zentol commented on the issue: https://github.com/apache/flink/pull/3274 +1 from my side.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user WangTaoTheTonic commented on the issue:

          https://github.com/apache/flink/pull/3274

          @zentol Is it ok to go?

          Show
          githubbot ASF GitHub Bot added a comment - Github user WangTaoTheTonic commented on the issue: https://github.com/apache/flink/pull/3274 @zentol Is it ok to go?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user tzulitai commented on the issue:

          https://github.com/apache/flink/pull/3274

          AFAIK, for simple changes we don't strictly require a separate PR for backporting to a release branch. Committers usually just cherry-pick the changes on the release branch.

          Show
          githubbot ASF GitHub Bot added a comment - Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/3274 AFAIK, for simple changes we don't strictly require a separate PR for backporting to a release branch. Committers usually just cherry-pick the changes on the release branch.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user WangTaoTheTonic commented on the issue:

          https://github.com/apache/flink/pull/3274

          Thanks. That makes sense

          Show
          githubbot ASF GitHub Bot added a comment - Github user WangTaoTheTonic commented on the issue: https://github.com/apache/flink/pull/3274 Thanks. That makes sense
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user greghogan commented on the issue:

          https://github.com/apache/flink/pull/3274

          I don't know the best workflow for multi-release PRs. It can work either way, so hopefully another developer will chime in here. I think we tend to only create a single PR for simple changes and the committer can patch the changes onto the stable branches.

          Show
          githubbot ASF GitHub Bot added a comment - Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3274 I don't know the best workflow for multi-release PRs. It can work either way, so hopefully another developer will chime in here. I think we tend to only create a single PR for simple changes and the committer can patch the changes onto the stable branches.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user WangTaoTheTonic commented on the issue:

          https://github.com/apache/flink/pull/3274

          Thanks @greghogan. Should I make another PR against branch `release-1.2`?

          Show
          githubbot ASF GitHub Bot added a comment - Github user WangTaoTheTonic commented on the issue: https://github.com/apache/flink/pull/3274 Thanks @greghogan. Should I make another PR against branch `release-1.2`?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user greghogan commented on the issue:

          https://github.com/apache/flink/pull/3274

          Travis is effectively passing. The tests are duplicated under multiple environments.

          This would also be a nice fix for 1.2.1.

          Show
          githubbot ASF GitHub Bot added a comment - Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3274 Travis is effectively passing. The tests are duplicated under multiple environments. This would also be a nice fix for 1.2.1.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user WangTaoTheTonic commented on the issue:

          https://github.com/apache/flink/pull/3274

          Travis timeout How to kick it up again?

          Show
          githubbot ASF GitHub Bot added a comment - Github user WangTaoTheTonic commented on the issue: https://github.com/apache/flink/pull/3274 Travis timeout How to kick it up again?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user WangTaoTheTonic commented on the issue:

          https://github.com/apache/flink/pull/3274

          @zentol Thanks for review. I've changed .jade file, but it looks like CI is not up properly

          Show
          githubbot ASF GitHub Bot added a comment - Github user WangTaoTheTonic commented on the issue: https://github.com/apache/flink/pull/3274 @zentol Thanks for review. I've changed .jade file, but it looks like CI is not up properly
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user zentol commented on the issue:

          https://github.com/apache/flink/pull/3274

          you have to modify the corresponding jade files; modifications to the html files will be overridden the next time someone builds the web-ui.

          Show
          githubbot ASF GitHub Bot added a comment - Github user zentol commented on the issue: https://github.com/apache/flink/pull/3274 you have to modify the corresponding jade files; modifications to the html files will be overridden the next time someone builds the web-ui.
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user WangTaoTheTonic opened a pull request:

          https://github.com/apache/flink/pull/3274

          FLINK-5723[UI]Use Used instead of Initial to make taskmanager tag more readable

          Now in JobManager web fronted, the used memory of task managers is presented as "Initial" in table header, which actually means "memory used", from codes.

          I'd like change it to be more readable, even it is trivial one.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/WangTaoTheTonic/flink changeheader

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/3274.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #3274


          commit 475e668aa1015c10cd69ffa88b6b0c4e3aeeb75f
          Author: unknown <wangtaothetonic@163.com>
          Date: 2017-02-06T15:18:38Z

          Use Used instead of Initial to make taskmanager tag more readable


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user WangTaoTheTonic opened a pull request: https://github.com/apache/flink/pull/3274 FLINK-5723 [UI] Use Used instead of Initial to make taskmanager tag more readable Now in JobManager web fronted, the used memory of task managers is presented as "Initial" in table header, which actually means "memory used", from codes. I'd like change it to be more readable, even it is trivial one. You can merge this pull request into a Git repository by running: $ git pull https://github.com/WangTaoTheTonic/flink changeheader Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3274.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3274 commit 475e668aa1015c10cd69ffa88b6b0c4e3aeeb75f Author: unknown <wangtaothetonic@163.com> Date: 2017-02-06T15:18:38Z Use Used instead of Initial to make taskmanager tag more readable

            People

            • Assignee:
              Unassigned
              Reporter:
              WangTao Tao Wang
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development