Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.3.0, 1.2.1
    • Component/s: Tests
    • Labels:
      None

      Description

      There are four types of Unit Test file: *ITCase.java, *Test.java, *ITSuite.scala, *Suite.scala
      File name ending with "IT.java" is integration test. File name ending with "Test.java" is unit test.

      It's clear for Surefire plugin of default-test execution to declare that "Test." is Java Unit Test.

      The test file statistics below:

      • Suite total: 10
      • ITCase total: 378
      • Test total: 1008
      • ITSuite total: 14

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user shijinkui opened a pull request:

          https://github.com/apache/flink/pull/3211

          cFLINK-5640[test]onfigure the explicit Unit Test file suffix

          There are four types of Unit Test file: *ITCase.java, *Test.java, *ITSuite.scala, *Suite.scala
          File name ending with "IT.java" is integration test. File name ending with "Test.java" is unit test.

          It's clear for Surefire plugin of default-test execution to declare that "Test." is Java Unit Test.

          The test file statistics:

          • Suite total: 10
          • ITCase total: 378
          • Test total: 1008
          • ITSuite total: 14

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/shijinkui/flink defined_ut_suffix

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/3211.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #3211


          commit aeea3f0b4cd9de5a3ea6a7eb37ce7b70d66d4942
          Author: shijinkui <shijinkui@huawei.com>
          Date: 2017-01-25T13:18:13Z

          cFLINK-5640[test]onfigure the explicit Unit Test file suffix


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user shijinkui opened a pull request: https://github.com/apache/flink/pull/3211 c FLINK-5640 [test] onfigure the explicit Unit Test file suffix There are four types of Unit Test file: *ITCase.java, *Test.java, *ITSuite.scala, *Suite.scala File name ending with "IT.java" is integration test. File name ending with "Test.java" is unit test. It's clear for Surefire plugin of default-test execution to declare that " Test. " is Java Unit Test. The test file statistics: Suite total: 10 ITCase total: 378 Test total: 1008 ITSuite total: 14 You can merge this pull request into a Git repository by running: $ git pull https://github.com/shijinkui/flink defined_ut_suffix Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3211.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3211 commit aeea3f0b4cd9de5a3ea6a7eb37ce7b70d66d4942 Author: shijinkui <shijinkui@huawei.com> Date: 2017-01-25T13:18:13Z c FLINK-5640 [test] onfigure the explicit Unit Test file suffix
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user shijinkui commented on the issue:

          https://github.com/apache/flink/pull/3211

          cc @rmetzger

          Show
          githubbot ASF GitHub Bot added a comment - Github user shijinkui commented on the issue: https://github.com/apache/flink/pull/3211 cc @rmetzger
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user StephanEwen commented on the issue:

          https://github.com/apache/flink/pull/3211

          Can you briefly explain what this fixes? Currently, it behaves exactly like you describe: The "test" phase executes the `*Test.java` and `*Test.scala` classes, and the "verify" phase executes the `*ITCase.java` and `*ITCase.scala` classes.

          Also, the changes to the compiler plugin - what is the purpose and effect of setting it to "verbose"?

          Show
          githubbot ASF GitHub Bot added a comment - Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3211 Can you briefly explain what this fixes? Currently, it behaves exactly like you describe: The "test" phase executes the `*Test.java` and `*Test.scala` classes, and the "verify" phase executes the `*ITCase.java` and `*ITCase.scala` classes. Also, the changes to the compiler plugin - what is the purpose and effect of setting it to "verbose"?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user shijinkui commented on the issue:

          https://github.com/apache/flink/pull/3211

          @StephanEwen Thank for your quickly reviewing.
          >`<include>**/Test.</include>`
          This can clearly show what unit test's file name like, just like `integration-tests` does. If omitting the `include`, it means that all the class file except `**/ITCase.` should be unit test, not only `Test.`.

          Show
          githubbot ASF GitHub Bot added a comment - Github user shijinkui commented on the issue: https://github.com/apache/flink/pull/3211 @StephanEwen Thank for your quickly reviewing. >`<include>**/ Test. </include>` This can clearly show what unit test's file name like, just like `integration-tests` does. If omitting the `include`, it means that all the class file except `**/ ITCase. ` should be unit test, not only ` Test. `.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user StephanEwen commented on the issue:

          https://github.com/apache/flink/pull/3211

          @shijinkui I think the Unite test include pattern is a good change, would merge that.

          Can we exclude the changes to the compiler configuration from the initial change?

          Show
          githubbot ASF GitHub Bot added a comment - Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3211 @shijinkui I think the Unite test include pattern is a good change, would merge that. Can we exclude the changes to the compiler configuration from the initial change?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user shijinkui commented on the issue:

          https://github.com/apache/flink/pull/3211

          @StephanEwen have finished that.

          Show
          githubbot ASF GitHub Bot added a comment - Github user shijinkui commented on the issue: https://github.com/apache/flink/pull/3211 @StephanEwen have finished that.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user StephanEwen commented on the issue:

          https://github.com/apache/flink/pull/3211

          Change looks good, thanks!

          Merging this...

          Show
          githubbot ASF GitHub Bot added a comment - Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3211 Change looks good, thanks! Merging this...
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/3211

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3211
          Hide
          StephanEwen Stephan Ewen added a comment -

          Fixed in

          • 1.2.1 via efa5e9d4b83277a34ac20d1a258727b7008a8ec1
          • 1.3.0 via 4ce2557da623d84f160fa3993b8e27590752fedb
          Show
          StephanEwen Stephan Ewen added a comment - Fixed in 1.2.1 via efa5e9d4b83277a34ac20d1a258727b7008a8ec1 1.3.0 via 4ce2557da623d84f160fa3993b8e27590752fedb

            People

            • Assignee:
              shijinkui shijinkui
              Reporter:
              shijinkui shijinkui
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development