[FLINK-5541] Missing null check for localJar in FlinkSubmitter#submitTopology()

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.4.0
• Component/s: Legacy Components / Storm Compatibility
• Assignee: zhangminglei
• Reporter: Ted Yu
• Created: 17/Jan/17 21:24
• Updated: 19/Jul/17 14:53
• Resolved: 19/Jul/17 14:53

Description

      if (localJar == null) {
        try {
          for (final URL url : ((ContextEnvironment) ExecutionEnvironment.getExecutionEnvironment())
              .getJars()) {
            // TODO verify that there is only one jar
            localJar = new File(url.toURI()).getAbsolutePath();
          }
        } catch (final URISyntaxException e) {
          // ignore
        } catch (final ClassCastException e) {
          // ignore
        }
      }

      logger.info("Submitting topology " + name + " in distributed mode with conf " + serConf);
      client.submitTopologyWithOpts(name, localJar, topology);

Since the try block may encounter URISyntaxException / ClassCastException, we should check that localJar is not null before calling submitTopologyWithOpts().

Issue Links

• links to: GitHub Pull Request #4315