Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-5515

fix unused kvState.getSerializedValue call in KvStateServerHandler

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.2.0, 1.3.0
    • Component/s: None
    • Labels:
      None

      Description

      This was added in 4809f5367b08a9734fc1bd4875be51a9f3bb65aa and is probably a left-over from a merge.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user NicoK opened a pull request:

          https://github.com/apache/flink/pull/3131

          FLINK-5515 remove unused kvState.getSerializedValue call in KvStateServerHandler

          this seems like a simple left-over from a merge that is doing unnecessary extra work

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/NicoK/flink flink-5515

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/3131.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #3131


          commit a92186af10e1dfa035f1650a7aaa3450b91ab037
          Author: Nico Kruber <nico@data-artisans.com>
          Date: 2017-01-16T17:45:49Z

          FLINK-5515 remove unused kvState.getSerializedValue call in KvStateServerHandler


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user NicoK opened a pull request: https://github.com/apache/flink/pull/3131 FLINK-5515 remove unused kvState.getSerializedValue call in KvStateServerHandler this seems like a simple left-over from a merge that is doing unnecessary extra work You can merge this pull request into a Git repository by running: $ git pull https://github.com/NicoK/flink flink-5515 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3131.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3131 commit a92186af10e1dfa035f1650a7aaa3450b91ab037 Author: Nico Kruber <nico@data-artisans.com> Date: 2017-01-16T17:45:49Z FLINK-5515 remove unused kvState.getSerializedValue call in KvStateServerHandler
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user uce commented on the issue:

          https://github.com/apache/flink/pull/3131

          Good catch. Test failures are unrelated, merging.

          Show
          githubbot ASF GitHub Bot added a comment - Github user uce commented on the issue: https://github.com/apache/flink/pull/3131 Good catch. Test failures are unrelated, merging.
          Hide
          uce Ufuk Celebi added a comment -

          Fixed in 6e85106 (release-1.2), ddd7c36 (master).

          Show
          uce Ufuk Celebi added a comment - Fixed in 6e85106 (release-1.2), ddd7c36 (master).
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/3131

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3131

            People

            • Assignee:
              Unassigned
              Reporter:
              NicoK Nico Kruber
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development