Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-5495

ZooKeeperMesosWorkerStore cannot be instantiated

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 1.2.0, 1.3.0
    • Fix Version/s: 1.2.0, 1.3.0
    • Component/s: Mesos
    • Labels:
      None

      Description

      The ZooKeeperMesosWorkerStore cannot be instantiated because it dynamically instantiates a ZooKeeperStateHandleStore without providing an Executor to the constructor. This effectively breaks Mesos HA mode.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user tillrohrmann opened a pull request:

          https://github.com/apache/flink/pull/3155

          FLINK-5495 [mesos] Provide executor to ZooKeeperMesosWorkerStore

          The ZooKeeperMesosWorkerStore instantiates a ZooKeeperStateHandleStore which requires an
          Executor instance. This executor is now given to the ZooKeeperMesosWorkerStore.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/tillrohrmann/flink mesosFixStateHandleStore

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/3155.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #3155


          commit dd2f56568745ade036de4d0ee333e7e7fdb47400
          Author: Till Rohrmann <trohrmann@apache.org>
          Date: 2017-01-16T13:14:18Z

          FLINK-5495 [mesos] Provide executor to ZooKeeperMesosWorkerStore

          The ZooKeeperMesosWorkerStore instantiates a ZooKeeperStateHandleStore which requires an
          Executor instance. This executor is now given to the ZooKeeperMesosWorkerStore.


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/3155 FLINK-5495 [mesos] Provide executor to ZooKeeperMesosWorkerStore The ZooKeeperMesosWorkerStore instantiates a ZooKeeperStateHandleStore which requires an Executor instance. This executor is now given to the ZooKeeperMesosWorkerStore. You can merge this pull request into a Git repository by running: $ git pull https://github.com/tillrohrmann/flink mesosFixStateHandleStore Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3155.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3155 commit dd2f56568745ade036de4d0ee333e7e7fdb47400 Author: Till Rohrmann <trohrmann@apache.org> Date: 2017-01-16T13:14:18Z FLINK-5495 [mesos] Provide executor to ZooKeeperMesosWorkerStore The ZooKeeperMesosWorkerStore instantiates a ZooKeeperStateHandleStore which requires an Executor instance. This executor is now given to the ZooKeeperMesosWorkerStore.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user tzulitai commented on the issue:

          https://github.com/apache/flink/pull/3155

          +1 to merge, LGTM.

          Show
          githubbot ASF GitHub Bot added a comment - Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/3155 +1 to merge, LGTM.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user tillrohrmann commented on the issue:

          https://github.com/apache/flink/pull/3155

          Thanks for your review @tzulitai. Merging this PR.

          Show
          githubbot ASF GitHub Bot added a comment - Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/3155 Thanks for your review @tzulitai. Merging this PR.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/3155

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3155
          Hide
          till.rohrmann Till Rohrmann added a comment -

          1.3.0: Added via 0f5b5f47ddc83f1bbe2e5446cab26cde9ebe88f8
          1.2.0: Added via 404d425294184978979f79713727d871bf6516dd

          Show
          till.rohrmann Till Rohrmann added a comment - 1.3.0: Added via 0f5b5f47ddc83f1bbe2e5446cab26cde9ebe88f8 1.2.0: Added via 404d425294184978979f79713727d871bf6516dd

            People

            • Assignee:
              till.rohrmann Till Rohrmann
              Reporter:
              till.rohrmann Till Rohrmann
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development