Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-5492

BootstrapTools log wrong address of started ActorSystem

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.2.0, 1.3.0
    • Component/s: None
    • Labels:
      None

      Description

      When starting an ActorSystem via the Bootstrap tools, then the startActorSystem function logs the IP resolved from the provided hostname as the ActorSystem address. However, then the function uses the unresolved hostname to start the ActorSystem. Since Akka matches the ActorSystem's address and the destination address of the incoming message we should log the URL which is used to start the ActorSystem and not the resolved IP (messages with the IP will usually be rejected).

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user tillrohrmann opened a pull request:

          https://github.com/apache/flink/pull/3161

          FLINK-5492 [log] Log unresolved address when starting an ActorSystem

          With the Flakka changes we no longer resolve the given hostname into an IP. Thus,
          we should henceforth log the unresolved hostname as the external address under which the `ActorSystem` is reachable.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/tillrohrmann/flink loggingFixAddress

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/3161.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #3161


          commit 3ea1c04a775b163e1b91fd0ae094c9ba8e194588
          Author: Till Rohrmann <trohrmann@apache.org>
          Date: 2017-01-18T16:16:20Z

          FLINK-5492 [log] Log unresolved address when starting an ActorSystem

          With the Flakka changes we no longer resolve the given hostname into an IP. Thus,
          we should henceforth log the unresolved hostname as the address to which the
          ActorSystem binds to.


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/3161 FLINK-5492 [log] Log unresolved address when starting an ActorSystem With the Flakka changes we no longer resolve the given hostname into an IP. Thus, we should henceforth log the unresolved hostname as the external address under which the `ActorSystem` is reachable. You can merge this pull request into a Git repository by running: $ git pull https://github.com/tillrohrmann/flink loggingFixAddress Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3161.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3161 commit 3ea1c04a775b163e1b91fd0ae094c9ba8e194588 Author: Till Rohrmann <trohrmann@apache.org> Date: 2017-01-18T16:16:20Z FLINK-5492 [log] Log unresolved address when starting an ActorSystem With the Flakka changes we no longer resolve the given hostname into an IP. Thus, we should henceforth log the unresolved hostname as the address to which the ActorSystem binds to.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user fhueske commented on the issue:

          https://github.com/apache/flink/pull/3161

          +1 to merge

          Show
          githubbot ASF GitHub Bot added a comment - Github user fhueske commented on the issue: https://github.com/apache/flink/pull/3161 +1 to merge
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user tillrohrmann commented on the issue:

          https://github.com/apache/flink/pull/3161

          Thanks for the review @fhueske. Merging this PR.

          Show
          githubbot ASF GitHub Bot added a comment - Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/3161 Thanks for the review @fhueske. Merging this PR.
          Hide
          till.rohrmann Till Rohrmann added a comment -

          Fixed via 3b32d1bcf62d0eac819d952f8d6a47284b411a18

          Show
          till.rohrmann Till Rohrmann added a comment - Fixed via 3b32d1bcf62d0eac819d952f8d6a47284b411a18
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/3161

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3161
          Hide
          rmetzger Robert Metzger added a comment -

          I need to reopen this issue because one of the changes in this JIRA are not correct.

          I now see the following in the TaskManager logs:

          2017-01-25 09:45:41,289 INFO  org.apache.flink.runtime.taskmanager.TaskManager              - (Starting TaskManager actor system at {}:{}.,permanent-qa-cluster-master,0)
          
          Show
          rmetzger Robert Metzger added a comment - I need to reopen this issue because one of the changes in this JIRA are not correct. I now see the following in the TaskManager logs: 2017-01-25 09:45:41,289 INFO org.apache.flink.runtime.taskmanager.TaskManager - (Starting TaskManager actor system at {}:{}.,permanent-qa-cluster-master,0)
          Hide
          rmetzger Robert Metzger added a comment -

          I will provide a fix for the issue.

          Show
          rmetzger Robert Metzger added a comment - I will provide a fix for the issue.
          Hide
          till.rohrmann Till Rohrmann added a comment -

          Arg, you're right. The grizzled logger used in the Scala files does not support parameterized logging statements. Instead the idiomatic way is to use string interpolation.

          Show
          till.rohrmann Till Rohrmann added a comment - Arg, you're right. The grizzled logger used in the Scala files does not support parameterized logging statements. Instead the idiomatic way is to use string interpolation.
          Show
          rmetzger Robert Metzger added a comment - Fixed for 1.2 in http://git-wip-us.apache.org/repos/asf/flink/commit/887c074a Fixed for 1.3 in http://git-wip-us.apache.org/repos/asf/flink/commit/cf6b3fb2

            People

            • Assignee:
              till.rohrmann Till Rohrmann
              Reporter:
              till.rohrmann Till Rohrmann
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development