Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-5466

Make production environment default in gulpfile

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.2.0, 1.1.4
    • Fix Version/s: 1.2.0, 1.3.0, 1.1.5
    • Component/s: Webfrontend
    • Labels:
      None

      Description

      Currently the default environment set in our gulpfile is development, which lead to very large created JS files. When building the web UI we apparently forgot to set the environment to production (build via gulp production).

      Since this is likely to occur again, we should make the default environment production and make sure to use development manually.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user uce opened a pull request:

          https://github.com/apache/flink/pull/3100

          FLINK-5466 [webfrontend] Set environment to production in gulpfile

          The default environment was set to `development`, which leads to very large generated JS files. When building the web UI we apparently forgot to set the environment to `production` (build via `gulp production`).

          Since this is likely to occur again, I set the default environment to `production` and let users set the environment to `development` manually (via `gulp dev`).

          Now:
          ```
          rw-rr- 1 uce staff 42K Jan 12 10:43 index.js
          rw-rr- 1 uce staff 931K Jan 12 10:43 vendor.js
          ```

          Before:
          ```
          rw-rr- 1 uce staff 328K Jan 12 10:49 index.js
          rw-rr- 1 uce staff 8.4M Jan 12 10:49 vendor.js
          ```

          I would like to merge this to the 1.1 and 1.2 branches as well.

          /cc @joerg84

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/uce/flink 5466-prod

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/3100.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #3100


          commit bd666810aa2df86206b607199139dedb23910b84
          Author: Ufuk Celebi <uce@apache.org>
          Date: 2017-01-12T09:46:31Z

          FLINK-5466 [webfrontend] Set environment to production in gulpfile


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user uce opened a pull request: https://github.com/apache/flink/pull/3100 FLINK-5466 [webfrontend] Set environment to production in gulpfile The default environment was set to `development`, which leads to very large generated JS files. When building the web UI we apparently forgot to set the environment to `production` (build via `gulp production`). Since this is likely to occur again, I set the default environment to `production` and let users set the environment to `development` manually (via `gulp dev`). Now: ``` rw-r r - 1 uce staff 42K Jan 12 10:43 index.js rw-r r - 1 uce staff 931K Jan 12 10:43 vendor.js ``` Before: ``` rw-r r - 1 uce staff 328K Jan 12 10:49 index.js rw-r r - 1 uce staff 8.4M Jan 12 10:49 vendor.js ``` I would like to merge this to the 1.1 and 1.2 branches as well. /cc @joerg84 You can merge this pull request into a Git repository by running: $ git pull https://github.com/uce/flink 5466-prod Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3100.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3100 commit bd666810aa2df86206b607199139dedb23910b84 Author: Ufuk Celebi <uce@apache.org> Date: 2017-01-12T09:46:31Z FLINK-5466 [webfrontend] Set environment to production in gulpfile
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user joerg84 commented on the issue:

          https://github.com/apache/flink/pull/3100

          LGTM, thanks for fixing this!

          Show
          githubbot ASF GitHub Bot added a comment - Github user joerg84 commented on the issue: https://github.com/apache/flink/pull/3100 LGTM, thanks for fixing this!
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user rmetzger commented on the issue:

          https://github.com/apache/flink/pull/3100

          +1 to merge.

          Show
          githubbot ASF GitHub Bot added a comment - Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/3100 +1 to merge.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user greghogan commented on the issue:

          https://github.com/apache/flink/pull/3100

          +1 to merge and backport. This is a big improvement when accessing the web UI over a slow connection.

          Show
          githubbot ASF GitHub Bot added a comment - Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3100 +1 to merge and backport. This is a big improvement when accessing the web UI over a slow connection.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/3100

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3100
          Hide
          uce Ufuk Celebi added a comment -

          FIxed in
          12cf5dc, 4ea52d6 (release-1.1),
          e55d426, 624f8ae (release-1.2),
          408f6ea, e1181f6 (master).

          Show
          uce Ufuk Celebi added a comment - FIxed in 12cf5dc, 4ea52d6 (release-1.1), e55d426, 624f8ae (release-1.2), 408f6ea, e1181f6 (master).

            People

            • Assignee:
              uce Ufuk Celebi
              Reporter:
              uce Ufuk Celebi
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development