Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-5276

ExecutionVertex archiving can throw NPE with many previous attempts

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.1.4
    • Component/s: JobManager
    • Labels:
      None

      Description

      I saw a NPE while archiving a ExecutionVertex:

      execution graph org.apache.flink.runtime.executiongraph.ExecutionGraph@c4e0722 for archiving.
      java.lang.NullPointerException: null
      	at org.apache.flink.runtime.executiongraph.ExecutionVertex.prepareForArchiving(ExecutionVertex.java:583)
      	at org.apache.flink.runtime.executiongraph.ExecutionJobVertex.prepareForArchiving(ExecutionJobVertex.java:439)
      	at org.apache.flink.runtime.executiongraph.ExecutionGraph.prepareForArchiving(ExecutionGraph.java:1042)
      ...
      

      I think this is due to the newly introduced EvictingBoundedList which returns a default element (null)) for evicted elements when iterating over it.

      This affects the backport to release-1.1 only.

        Issue Links

          Activity

          Hide
          uce Ufuk Celebi added a comment -

          Fixed in 75b48e (release-1.1)

          Show
          uce Ufuk Celebi added a comment - Fixed in 75b48e (release-1.1)
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user uce closed the pull request at:

          https://github.com/apache/flink/pull/2957

          Show
          githubbot ASF GitHub Bot added a comment - Github user uce closed the pull request at: https://github.com/apache/flink/pull/2957
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user StefanRRichter commented on the issue:

          https://github.com/apache/flink/pull/2957

          LGTM +1

          Show
          githubbot ASF GitHub Bot added a comment - Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/2957 LGTM +1
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user uce opened a pull request:

          https://github.com/apache/flink/pull/2957

          FLINK-5276 [eg] Check for null when archiving prior execution attempts

          The `EvictingBoundedList` returns the default value for all evicted elements. This could lead to NPE when archiving an `ExecutionVertex`.

          /cc @StefanRRichter

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/uce/flink 5276-archive_execvertex_npe

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/2957.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #2957


          commit c1f90b70cedc7c5d942a67dcc0b12068dbf5acd7
          Author: Ufuk Celebi <uce@apache.org>
          Date: 2016-12-07T13:26:35Z

          FLINK-5276 [eg] Check for null when archiving prior execution attempts


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user uce opened a pull request: https://github.com/apache/flink/pull/2957 FLINK-5276 [eg] Check for null when archiving prior execution attempts The `EvictingBoundedList` returns the default value for all evicted elements. This could lead to NPE when archiving an `ExecutionVertex`. /cc @StefanRRichter You can merge this pull request into a Git repository by running: $ git pull https://github.com/uce/flink 5276-archive_execvertex_npe Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/2957.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2957 commit c1f90b70cedc7c5d942a67dcc0b12068dbf5acd7 Author: Ufuk Celebi <uce@apache.org> Date: 2016-12-07T13:26:35Z FLINK-5276 [eg] Check for null when archiving prior execution attempts

            People

            • Assignee:
              uce Ufuk Celebi
              Reporter:
              uce Ufuk Celebi
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development