Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-5149

ContinuousEventTimeTrigger doesn't fire at the end of the window

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.2.0, 1.1.3
    • Fix Version/s: 1.2.0, 1.1.4
    • Component/s: Streaming
    • Labels:
      None

      Description

      The ContinuousEventTimeTrigger registers a timer when elements arrive. The timers might be registered past the end of the window. In this case, the window is cleaned up and doesn't fire at all. That is certainly not what users have in mind when they use the custom trigger.

      I proposed to let it behave like a normal EventTimeTrigger in addition to its continuous firing capabilities. So it should fire at the end of the window regardless of timers set.

        Issue Links

          Activity

          Hide
          mxm Maximilian Michels added a comment -

          master: 2029c14eb7d5b6788eb9297c271dd16a0d819fbe
          release-1.1: fc24c30ee0edb3a66196629cece942bb8a0b155c

          Show
          mxm Maximilian Michels added a comment - master: 2029c14eb7d5b6788eb9297c271dd16a0d819fbe release-1.1: fc24c30ee0edb3a66196629cece942bb8a0b155c
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/2860

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2860
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user mxm commented on the issue:

          https://github.com/apache/flink/pull/2860

          Thanks, I'll leave this open for a bit. I wasn't aware we also had an issue for removing the trigger. I don't know how useful it is to users.

          Show
          githubbot ASF GitHub Bot added a comment - Github user mxm commented on the issue: https://github.com/apache/flink/pull/2860 Thanks, I'll leave this open for a bit. I wasn't aware we also had an issue for removing the trigger. I don't know how useful it is to users.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user aljoscha commented on the issue:

          https://github.com/apache/flink/pull/2860

          I thinks it's fine, though, and will close my PR and Issue. Please go ahead and merge.

          Show
          githubbot ASF GitHub Bot added a comment - Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/2860 I thinks it's fine, though, and will close my PR and Issue. Please go ahead and merge.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user aljoscha commented on the issue:

          https://github.com/apache/flink/pull/2860

          There's also #2803 ... 😉

          Show
          githubbot ASF GitHub Bot added a comment - Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/2860 There's also #2803 ... 😉
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user mxm commented on the issue:

          https://github.com/apache/flink/pull/2860

          CC @kl0u @aljoscha

          Show
          githubbot ASF GitHub Bot added a comment - Github user mxm commented on the issue: https://github.com/apache/flink/pull/2860 CC @kl0u @aljoscha
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user mxm opened a pull request:

          https://github.com/apache/flink/pull/2860

          FLINK-5149 let ContinuousEventTimeTrigger fire at the end of the window

          This changes the ContinuousEventTimeTrigger to behave like the
          EventTimeTrigger in the sense that it also triggers at the end of the
          window.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/mxm/flink FLINK-5149

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/2860.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #2860


          commit 18d3c2bd2dee225e274d0eda3bc7e5ccbe1ba3df
          Author: Maximilian Michels <mxm@apache.org>
          Date: 2016-11-23T15:01:35Z

          FLINK-5149 let ContinuousEventTimeTrigger fire at the end of the window

          This changes the ContinuousEventTimeTrigger to behave like the
          EventTimeTrigger in the sense that it also triggers at the end of the
          window.


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user mxm opened a pull request: https://github.com/apache/flink/pull/2860 FLINK-5149 let ContinuousEventTimeTrigger fire at the end of the window This changes the ContinuousEventTimeTrigger to behave like the EventTimeTrigger in the sense that it also triggers at the end of the window. You can merge this pull request into a Git repository by running: $ git pull https://github.com/mxm/flink FLINK-5149 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/2860.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2860 commit 18d3c2bd2dee225e274d0eda3bc7e5ccbe1ba3df Author: Maximilian Michels <mxm@apache.org> Date: 2016-11-23T15:01:35Z FLINK-5149 let ContinuousEventTimeTrigger fire at the end of the window This changes the ContinuousEventTimeTrigger to behave like the EventTimeTrigger in the sense that it also triggers at the end of the window.

            People

            • Assignee:
              mxm Maximilian Michels
              Reporter:
              mxm Maximilian Michels
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development