Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-5082

Pull ExecutionService lifecycle management out of the JobManager

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.2.0, 1.1.3
    • Fix Version/s: 1.2.0, 1.1.4
    • Component/s: JobManager
    • Labels:
      None

      Description

      The JobManager receives an ExecutorService to run its futures as a constructor parameter. Even though the ExecutorService comes from outside, the JobManager shuts the executor service down if the JobManager terminates. This is clearly a sub-optimal behaviour leading also to RejectedExecutionExceptions.

      I propose to move the ExecutorService lifecycle management out of the JobManager.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user tillrohrmann opened a pull request:

          https://github.com/apache/flink/pull/2820

          FLINK-5082 Pull ExecutorService lifecycle management out of the JobManager

          The provided ExecutorService will no longer be closed by the JobManager. Instead the
          lifecycle is managed outside of it where it was created. This will give a nicer behaviour,
          because it better separates responsibilities.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/tillrohrmann/flink executorLifecycleManagement

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/2820.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #2820


          commit 6bba4042b09110c8da016897b2f744e411bfb6bb
          Author: Till Rohrmann <trohrmann@apache.org>
          Date: 2016-11-16T17:33:54Z

          FLINK-5082 Pull ExecutorService lifecycle management out of the JobManager

          The provided ExecutorService will no longer be closed by the JobManager. Instead the
          lifecycle is managed outside of it where it was created. This will give a nicer behaviour,
          because it better seperates responsibilities.


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/2820 FLINK-5082 Pull ExecutorService lifecycle management out of the JobManager The provided ExecutorService will no longer be closed by the JobManager. Instead the lifecycle is managed outside of it where it was created. This will give a nicer behaviour, because it better separates responsibilities. You can merge this pull request into a Git repository by running: $ git pull https://github.com/tillrohrmann/flink executorLifecycleManagement Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/2820.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2820 commit 6bba4042b09110c8da016897b2f744e411bfb6bb Author: Till Rohrmann <trohrmann@apache.org> Date: 2016-11-16T17:33:54Z FLINK-5082 Pull ExecutorService lifecycle management out of the JobManager The provided ExecutorService will no longer be closed by the JobManager. Instead the lifecycle is managed outside of it where it was created. This will give a nicer behaviour, because it better seperates responsibilities.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/2820

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2820
          Hide
          till.rohrmann Till Rohrmann added a comment -

          Fixed in 1.2 via ae4b274a9919d01a236df4e819a0a07c5d8543ac
          Fixed in 1.1.4 via 7fb71c5bf1aab85250bf29bd0ea0654079cea48f

          Show
          till.rohrmann Till Rohrmann added a comment - Fixed in 1.2 via ae4b274a9919d01a236df4e819a0a07c5d8543ac Fixed in 1.1.4 via 7fb71c5bf1aab85250bf29bd0ea0654079cea48f

            People

            • Assignee:
              till.rohrmann Till Rohrmann
              Reporter:
              till.rohrmann Till Rohrmann
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development