Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-5057

Cancellation timeouts are picked from wrong config

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.2.0, 1.1.4
    • Component/s: None
    • Labels:
      None

      Description

      The cancellation timeouts are read from the Task configuration instead of the TaskManager configuration.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user uce opened a pull request:

          https://github.com/apache/flink/pull/2793

          FLINK-5057 [task] Pick cancellation timeout from task manager config

          This was previously picked from the wrong config (the Task config). There was a test for it, but it was also testing the task config.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/uce/flink 5057-cancelation_tmconfig

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/2793.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #2793


          commit 9abb5e148138746a61b9be77c1daf5e5b925257a
          Author: Ufuk Celebi <uce@apache.org>
          Date: 2016-11-12T19:19:15Z

          FLINK-5057 [task] Pick cancellation timeout from task manager config


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user uce opened a pull request: https://github.com/apache/flink/pull/2793 FLINK-5057 [task] Pick cancellation timeout from task manager config This was previously picked from the wrong config (the Task config). There was a test for it, but it was also testing the task config. You can merge this pull request into a Git repository by running: $ git pull https://github.com/uce/flink 5057-cancelation_tmconfig Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/2793.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2793 commit 9abb5e148138746a61b9be77c1daf5e5b925257a Author: Ufuk Celebi <uce@apache.org> Date: 2016-11-12T19:19:15Z FLINK-5057 [task] Pick cancellation timeout from task manager config
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user uce opened a pull request:

          https://github.com/apache/flink/pull/2794

          [backport] FLINK-5057 [task] Pick cancellation timeout from task manager config

          Backport of #2793 with no major changes. This should be merged for 1.1.4 (requiring a new RC).

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/uce/flink 5057-cancelation_tmconfig-backport_1.1

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/2794.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #2794


          commit 545bb4f93303831b9e29dfa57f5d151b77f5a6e2
          Author: Ufuk Celebi <uce@apache.org>
          Date: 2016-11-12T19:19:15Z

          FLINK-5057 [task] Pick cancellation timeout from task manager config


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user uce opened a pull request: https://github.com/apache/flink/pull/2794 [backport] FLINK-5057 [task] Pick cancellation timeout from task manager config Backport of #2793 with no major changes. This should be merged for 1.1.4 (requiring a new RC). You can merge this pull request into a Git repository by running: $ git pull https://github.com/uce/flink 5057-cancelation_tmconfig-backport_1.1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/2794.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2794 commit 545bb4f93303831b9e29dfa57f5d151b77f5a6e2 Author: Ufuk Celebi <uce@apache.org> Date: 2016-11-12T19:19:15Z FLINK-5057 [task] Pick cancellation timeout from task manager config
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user StephanEwen commented on the issue:

          https://github.com/apache/flink/pull/2794

          Merging this...

          Show
          githubbot ASF GitHub Bot added a comment - Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2794 Merging this...
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/2793

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2793
          Hide
          StephanEwen Stephan Ewen added a comment -

          Fixed in

          • 1.1.4 via ad3e674b26fb5766ffefda653701af5180d60413
          • 1.2.0 via bf06a1cc786c0a7b8c8d446be01a63edf2cc0897
          Show
          StephanEwen Stephan Ewen added a comment - Fixed in 1.1.4 via ad3e674b26fb5766ffefda653701af5180d60413 1.2.0 via bf06a1cc786c0a7b8c8d446be01a63edf2cc0897
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user uce closed the pull request at:

          https://github.com/apache/flink/pull/2794

          Show
          githubbot ASF GitHub Bot added a comment - Github user uce closed the pull request at: https://github.com/apache/flink/pull/2794

            People

            • Assignee:
              uce Ufuk Celebi
              Reporter:
              uce Ufuk Celebi
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development