Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.2.0, 1.1.4
    • Component/s: None
    • Labels:
      None

      Description

      We should exclude org.json:json dependency from hive-exec dependency.

      [INFO] +- org.apache.flink:flink-java:jar:1.2-SNAPSHOT:provided
      ...
      [INFO] +- org.apache.hive.hcatalog:hcatalog-core:jar:0.12.0:compile
      ...
      [INFO] |  +- org.apache.hive:hive-exec:jar:0.12.0:compile
      [INFO] |  |  +- com.google.protobuf:protobuf-java:jar:2.4.1:compile
      [INFO] |  |  +- org.iq80.snappy:snappy:jar:0.2:compile
      [INFO] |  |  +- org.json:json:jar:20090211:compile
      

        Issue Links

          Activity

          Hide
          StephanEwen Stephan Ewen added a comment -

          Thank you for the contribution!

          Show
          StephanEwen Stephan Ewen added a comment - Thank you for the contribution!
          Hide
          StephanEwen Stephan Ewen added a comment -

          Fixed in

          • 1.1.4 via ca9080958c042ec16d4f5d422fccb482e283f614
          • 1.2.0 via 973ce7d0eb219ea84ad6b7fd0d063f595485205f
          Show
          StephanEwen Stephan Ewen added a comment - Fixed in 1.1.4 via ca9080958c042ec16d4f5d422fccb482e283f614 1.2.0 via 973ce7d0eb219ea84ad6b7fd0d063f595485205f
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/2824

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2824
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user StephanEwen commented on the issue:

          https://github.com/apache/flink/pull/2824

          +1, merging this

          Show
          githubbot ASF GitHub Bot added a comment - Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2824 +1, merging this
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user tedyu commented on the issue:

          https://github.com/apache/flink/pull/2824

          lgtm

          Show
          githubbot ASF GitHub Bot added a comment - Github user tedyu commented on the issue: https://github.com/apache/flink/pull/2824 lgtm
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user bitchelov opened a pull request:

          https://github.com/apache/flink/pull/2824

          FLINK-5050 JSON.org license is CatX

          Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
          If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
          In addition to going through the list, please provide a meaningful description of your changes.

          • [ ] General
          • The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
          • The pull request addresses only one issue
          • Each commit in the PR has a meaningful commit message (including the JIRA id)
          • [ ] Documentation
          • Documentation has been added for new functionality
          • Old documentation affected by the pull request has been updated
          • JavaDoc for public methods has been added
          • [ ] Tests & Build
          • Functionality added by the pull request is covered by tests
          • `mvn clean verify` has been executed successfully locally or a Travis build has passed

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/bitchelov/flink json_dependency

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/2824.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #2824


          commit 28d8535d59ecee433b54b486be2bbe5d11b9a3e6
          Author: sergey_sokur <sokurito@gmail.com>
          Date: 2016-11-17T16:28:20Z

          FLINK-5050 JSON.org license is CatX


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user bitchelov opened a pull request: https://github.com/apache/flink/pull/2824 FLINK-5050 JSON.org license is CatX Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration. If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide] ( http://flink.apache.org/how-to-contribute.html ). In addition to going through the list, please provide a meaningful description of your changes. [ ] General The pull request references the related JIRA issue (" [FLINK-XXX] Jira title text") The pull request addresses only one issue Each commit in the PR has a meaningful commit message (including the JIRA id) [ ] Documentation Documentation has been added for new functionality Old documentation affected by the pull request has been updated JavaDoc for public methods has been added [ ] Tests & Build Functionality added by the pull request is covered by tests `mvn clean verify` has been executed successfully locally or a Travis build has passed You can merge this pull request into a Git repository by running: $ git pull https://github.com/bitchelov/flink json_dependency Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/2824.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2824 commit 28d8535d59ecee433b54b486be2bbe5d11b9a3e6 Author: sergey_sokur <sokurito@gmail.com> Date: 2016-11-17T16:28:20Z FLINK-5050 JSON.org license is CatX
          Hide
          yuzhihong@gmail.com Ted Yu added a comment -

          We can just exclude dependency on org.json

          Show
          yuzhihong@gmail.com Ted Yu added a comment - We can just exclude dependency on org.json
          Hide
          StephanEwen Stephan Ewen added a comment -

          Do we need the hive-exec dependency, or can we exclude that as a whole?

          Show
          StephanEwen Stephan Ewen added a comment - Do we need the hive-exec dependency, or can we exclude that as a whole?

            People

            • Assignee:
              Sergey Sokur Sergey_Sokur
              Reporter:
              yuzhihong@gmail.com Ted Yu
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development