Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-4778

Update program example in /docs/setup/cli.md due to the change in FLINK-2021

    Details

    • Type: Task
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.2.0, 1.1.4
    • Component/s: None

      Description

      According to FLINK-2021, ParameterTool was introduced hence all input parameters need to send with its corresponding prefix such as

       --input, --output 

      However, WordCount call in https://github.com/apache/flink/blob/master/docs/setup/cli.md#examples hasn't been updated yet.

      REF: https://github.com/apache/flink/commit/0629e25602eefdc239e8e72d9e3c9c1a5164448e

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user fhueske commented on the issue:

          https://github.com/apache/flink/pull/2611

          Thanks for the PR @heytitle!
          Good to merge

          Show
          githubbot ASF GitHub Bot added a comment - Github user fhueske commented on the issue: https://github.com/apache/flink/pull/2611 Thanks for the PR @heytitle! Good to merge
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user fhueske commented on the issue:

          https://github.com/apache/flink/pull/2611

          Merging

          Show
          githubbot ASF GitHub Bot added a comment - Github user fhueske commented on the issue: https://github.com/apache/flink/pull/2611 Merging
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/2611

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2611
          Hide
          fhueske Fabian Hueske added a comment -

          Fixed for 1.1.x with 2203f743a6bfd2db483603d1f45e210cee935f17
          Fixed for 1.2.0 with a079259f3cfe3dc0717439fd65ce5de17cf69fb5

          Show
          fhueske Fabian Hueske added a comment - Fixed for 1.1.x with 2203f743a6bfd2db483603d1f45e210cee935f17 Fixed for 1.2.0 with a079259f3cfe3dc0717439fd65ce5de17cf69fb5
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user heytitle commented on the issue:

          https://github.com/apache/flink/pull/2611

          @fhueske you're welcome ๐Ÿ˜„

          Show
          githubbot ASF GitHub Bot added a comment - Github user heytitle commented on the issue: https://github.com/apache/flink/pull/2611 @fhueske you're welcome ๐Ÿ˜„

            People

            • Assignee:
              Unassigned
              Reporter:
              heytitle Pattarawat Chormai
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development