Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-4663

Flink JDBCOutputFormat logs wrong WARN message

        Details

          Description

          Flink JDBCOutputFormat logs wrong WARN message as
          "Column SQL types array doesn't match arity of passed Row! Check the passed array..."
          even if there is no mismatch is SQL types array & arity of passed Row.

          (flink/flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCOutputFormat.java)

          It logs lot of unnecessary warning messages (one per row passed) in log files.

            Issue Links

            links to

            Web Link GitHub Pull Request #2534

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              the.swapnil09@gmail.com Swapnil Chougule added a comment -

              Hi Team,

              Can anybody give me permissions to assign same JIRA to me ?

              Thanks,
              Swapnil

              Show
              the.swapnil09@gmail.com Swapnil Chougule added a comment - Hi Team, Can anybody give me permissions to assign same JIRA to me ? Thanks, Swapnil
              Hide
              Permalink
              githubbot ASF GitHub Bot added a comment -

              GitHub user swapnil-chougule opened a pull request:

              https://github.com/apache/flink/pull/2534

              FLINK-4663 Flink JDBCOutputFormat logs wrong WARN message - Fixed

              Fixed wrong WARN message logged by JDBCOutputFormat while adding row (writing record to prepared statement) as
              "Column SQL types array doesn't match arity of passed Row! Check the passed array..."
              even if there is no mismatch is SQL types array & arity of passed Row. FLINK-4663

              • [ ] General
              • The pull request references the related JIRA issue ("FLINK-4663")
              • The pull request addresses only one issue
              • Each commit in the PR has a meaningful commit message (including the JIRA id)
              • [ ] Documentation
              • No need to change documentation for same.
              • [ ] Tests & Build
              • Functionality added by the pull request is covered by tests
              • `mvn clean verify` has been executed successfully locally or a Travis build has passed

              You can merge this pull request into a Git repository by running:

              $ git pull https://github.com/swapnil-chougule/flink FLINK-4663

              Alternatively you can review and apply these changes as the patch at:

              https://github.com/apache/flink/pull/2534.patch

              To close this pull request, make a commit to your master/trunk branch
              with (at least) the following in the commit message:

              This closes #2534

              commit a3a3a76164c717f079887a641598e3b9aa6ce484
              Author: swapnil-chougule <swapnil.chougule@pubmatic.com>
              Date: 2016-09-22T12:31:20Z

              FLINK-4663 Flink JDBCOutputFormat logs wrong WARN message - Fixed

              Show
              githubbot ASF GitHub Bot added a comment - GitHub user swapnil-chougule opened a pull request: https://github.com/apache/flink/pull/2534 FLINK-4663 Flink JDBCOutputFormat logs wrong WARN message - Fixed Fixed wrong WARN message logged by JDBCOutputFormat while adding row (writing record to prepared statement) as "Column SQL types array doesn't match arity of passed Row! Check the passed array..." even if there is no mismatch is SQL types array & arity of passed Row. FLINK-4663 [ ] General The pull request references the related JIRA issue (" FLINK-4663 ") The pull request addresses only one issue Each commit in the PR has a meaningful commit message (including the JIRA id) [ ] Documentation No need to change documentation for same. [ ] Tests & Build Functionality added by the pull request is covered by tests `mvn clean verify` has been executed successfully locally or a Travis build has passed You can merge this pull request into a Git repository by running: $ git pull https://github.com/swapnil-chougule/flink FLINK-4663 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/2534.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2534 commit a3a3a76164c717f079887a641598e3b9aa6ce484 Author: swapnil-chougule <swapnil.chougule@pubmatic.com> Date: 2016-09-22T12:31:20Z FLINK-4663 Flink JDBCOutputFormat logs wrong WARN message - Fixed
              Hide
              Permalink
              the.swapnil09@gmail.com Swapnil Chougule added a comment -

              Resolved. Created PR
              https://github.com/apache/flink/pull/2534
              Kindly review.

              Regards,
              Swapnil

              Show
              the.swapnil09@gmail.com Swapnil Chougule added a comment - Resolved. Created PR https://github.com/apache/flink/pull/2534 Kindly review. Regards, Swapnil
              Hide
              Permalink
              fhueske Fabian Hueske added a comment -

              Hi Swapnil Chougule, thanks for providing a fix!
              We will close the issue once the pull request is merged.
              Thanks, Fabian

              Show
              fhueske Fabian Hueske added a comment - Hi Swapnil Chougule , thanks for providing a fix! We will close the issue once the pull request is merged. Thanks, Fabian
              Hide
              Permalink
              githubbot ASF GitHub Bot added a comment -

              Github user zentol commented on the issue:

              https://github.com/apache/flink/pull/2534

              +1 to merge.

              Show
              githubbot ASF GitHub Bot added a comment - Github user zentol commented on the issue: https://github.com/apache/flink/pull/2534 +1 to merge.
              Hide
              Permalink
              githubbot ASF GitHub Bot added a comment -

              Github user StephanEwen commented on the issue:

              https://github.com/apache/flink/pull/2534

              Merging this...

              Show
              githubbot ASF GitHub Bot added a comment - Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2534 Merging this...
              Hide
              Permalink
              githubbot ASF GitHub Bot added a comment -

              Github user asfgit closed the pull request at:

              https://github.com/apache/flink/pull/2534

              Show
              githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2534
              Hide
              Permalink
              StephanEwen Stephan Ewen added a comment -

              Fixed in

              • 1.2.0 via 335a2826481725aabc86de8068909060894a274b
              • 1.1.3 via 8fd08bf29fbd3ee8798f52a4196c07bb4363ddd3
              Show
              StephanEwen Stephan Ewen added a comment - Fixed in 1.2.0 via 335a2826481725aabc86de8068909060894a274b 1.1.3 via 8fd08bf29fbd3ee8798f52a4196c07bb4363ddd3

                People

                • Assignee:
                  the.swapnil09@gmail.com Swapnil Chougule
                  Reporter:
                  the.swapnil09@gmail.com Swapnil Chougule
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  4 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Development