[FLINK-4506] CsvOutputFormat defaults allowNullValues to false, even though doc and declaration says true

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.1.4, 1.2.0
• Component/s: API / DataSet, Documentation
• Assignee: Kirill Morozov
• Reporter: Michael Wong
• Created: 26/Aug/16 10:11
• Updated: 28/Feb/19 13:46
• Resolved: 15/Oct/16 07:54

Description

In the constructor, it has this

this.allowNullValues = false;

But in the setAllowNullValues() method, the doc says the allowNullValues is true by default. Also, in the declaration of allowNullValues, the value is set to true. It probably makes the most sense to change the constructor.

	/**
	 * Configures the format to either allow null values (writing an empty field),
	 * or to throw an exception when encountering a null field.
	 * <p>
	 * by default, null values are allowed.
	 *
	 * @param allowNulls Flag to indicate whether the output format should accept null values.
	 */
	public void setAllowNullValues(boolean allowNulls) {
		this.allowNullValues = allowNulls;
	}

Issue Links

• links to: GitHub Pull Request #2477