Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-4506

CsvOutputFormat defaults allowNullValues to false, even though doc and declaration says true

    Details

      Description

      In the constructor, it has this

      this.allowNullValues = false;
      

      But in the setAllowNullValues() method, the doc says the allowNullValues is true by default. Also, in the declaration of allowNullValues, the value is set to true. It probably makes the most sense to change the constructor.

      	/**
      	 * Configures the format to either allow null values (writing an empty field),
      	 * or to throw an exception when encountering a null field.
      	 * <p>
      	 * by default, null values are allowed.
      	 *
      	 * @param allowNulls Flag to indicate whether the output format should accept null values.
      	 */
      	public void setAllowNullValues(boolean allowNulls) {
      		this.allowNullValues = allowNulls;
      	}
      

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user kirill-morozov-epam opened a pull request:

          https://github.com/apache/flink/pull/2477

          FLINK-4506 CsvOutputFormat defaults allowNullValues to false, even …

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/kirill-morozov-epam/flink FLINK-4506

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/2477.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #2477



          Show
          githubbot ASF GitHub Bot added a comment - GitHub user kirill-morozov-epam opened a pull request: https://github.com/apache/flink/pull/2477 FLINK-4506 CsvOutputFormat defaults allowNullValues to false, even … You can merge this pull request into a Git repository by running: $ git pull https://github.com/kirill-morozov-epam/flink FLINK-4506 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/2477.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2477
          Hide
          kirill-morozov-epam Kirill Morozov added a comment -

          Hi folks! Can anyone make a review of my PR ?

          Show
          kirill-morozov-epam Kirill Morozov added a comment - Hi folks! Can anyone make a review of my PR ?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user zentol commented on the issue:

          https://github.com/apache/flink/pull/2477

          I think should rather adjust the documentation to fit the current behavior. This discrepancy wasn't just introduced recently, as far as i can tell it has been there forever, or rather since the allowNullValues flag was introduced.

          Show
          githubbot ASF GitHub Bot added a comment - Github user zentol commented on the issue: https://github.com/apache/flink/pull/2477 I think should rather adjust the documentation to fit the current behavior. This discrepancy wasn't just introduced recently, as far as i can tell it has been there forever, or rather since the allowNullValues flag was introduced.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user fhueske commented on the issue:

          https://github.com/apache/flink/pull/2477

          I agree with @zentol. `this.allowNullValues = false;` is the behavior since the initial code import. I would not change this and rather fix the JavaDocs.

          Show
          githubbot ASF GitHub Bot added a comment - Github user fhueske commented on the issue: https://github.com/apache/flink/pull/2477 I agree with @zentol. `this.allowNullValues = false;` is the behavior since the initial code import. I would not change this and rather fix the JavaDocs.
          Hide
          mwong Michael Wong added a comment -

          Ok, but let's forget about what was there before for the moment. What is the desired behavior? What is the most likely setting people would want? My bet is allowNullValues=true.

          Show
          mwong Michael Wong added a comment - Ok, but let's forget about what was there before for the moment. What is the desired behavior? What is the most likely setting people would want? My bet is allowNullValues=true.
          Hide
          fhueske Fabian Hueske added a comment -

          I'm not sure about that. The CsvInputFormat supports tuple and Pojo data types, tuples being the common choice. However, tuples do not support null values and hence a null value will cause a NPE during serialization.

          Apart from that, I'm not in favor of changing the behavior of stable declared public interface without very good reason.

          Show
          fhueske Fabian Hueske added a comment - I'm not sure about that. The CsvInputFormat supports tuple and Pojo data types, tuples being the common choice. However, tuples do not support null values and hence a null value will cause a NPE during serialization. Apart from that, I'm not in favor of changing the behavior of stable declared public interface without very good reason.
          Hide
          kirill-morozov-epam Kirill Morozov added a comment -
          Show
          kirill-morozov-epam Kirill Morozov added a comment - Rollbacked to old behavior, documentation fixed: https://github.com/apache/flink/pull/2477/commits/34addbfdb5da0cef596e23ff8e1311954ac0682b
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user zentol commented on a diff in the pull request:

          https://github.com/apache/flink/pull/2477#discussion_r80887299

          — Diff: flink-java/src/test/java/org/apache/flink/api/java/io/CsvOutputFormatTest.java —
          @@ -0,0 +1,63 @@
          +/*
          + * Licensed to the Apache Software Foundation (ASF) under one
          + * or more contributor license agreements. See the NOTICE file
          + * distributed with this work for additional information
          + * regarding copyright ownership. The ASF licenses this file
          + * to you under the Apache License, Version 2.0 (the
          + * "License"); you may not use this file except in compliance
          + * with the License. You may obtain a copy of the License at
          + *
          + * http://www.apache.org/licenses/LICENSE-2.0
          + *
          + * Unless required by applicable law or agreed to in writing, software
          + * distributed under the License is distributed on an "AS IS" BASIS,
          + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
          + * See the License for the specific language governing permissions and
          + * limitations under the License.
          + */
          +
          +package org.apache.flink.api.java.io;
          +
          +import org.apache.commons.io.IOUtils;
          +import org.apache.flink.api.common.io.FileOutputFormat;
          +import org.apache.flink.api.java.tuple.Tuple3;
          +import org.apache.flink.core.fs.FSDataInputStream;
          +import org.apache.flink.core.fs.FileSystem;
          +import org.apache.flink.core.fs.Path;
          +import org.junit.Assert;
          +import org.junit.Test;
          +
          +import java.nio.charset.StandardCharsets;
          +
          +public class CsvOutputFormatTest {
          +
          + private static final Path PATH = new Path("csv_output_test_file.csv");
          +
          + @Test
          + public void testNullAllow() throws Exception

          { + CsvOutputFormat<Tuple3<String, String, Integer>> csvOutputFormat = new CsvOutputFormat<Tuple3<String, String, Integer>>(PATH); + csvOutputFormat.setWriteMode(FileSystem.WriteMode.OVERWRITE); + csvOutputFormat.setOutputDirectoryMode(FileOutputFormat.OutputDirectoryMode.PARONLY); + csvOutputFormat.setAllowNullValues(true); + csvOutputFormat.open(0, 1); + csvOutputFormat.writeRecord(new Tuple3<String, String, Integer>("One", null, 8)); + csvOutputFormat.close(); + final FileSystem fs = PATH.getFileSystem(); + Assert.assertTrue(fs.exists(PATH)); + FSDataInputStream inputStream = fs.open(PATH); + String csvContent = IOUtils.toString(inputStream, StandardCharsets.UTF_8); + Assert.assertEquals("One,,8\n", csvContent); + fs.delete(PATH, true); + }

          +
          + @Test(expected = RuntimeException.class)
          + public void testNullDisallowOnDefault() throws Exception {
          + CsvOutputFormat<Tuple3<String, String, Integer>> csvOutputFormat = new CsvOutputFormat<Tuple3<String, String, Integer>>(PATH);
          + csvOutputFormat.setWriteMode(FileSystem.WriteMode.OVERWRITE);
          + csvOutputFormat.setOutputDirectoryMode(FileOutputFormat.OutputDirectoryMode.PARONLY);
          + csvOutputFormat.open(0, 1);
          + csvOutputFormat.writeRecord(new Tuple3<String, String, Integer>("One", null, 8));
          + csvOutputFormat.close();
          — End diff –

          The temporary file is created within `open()` and will not be cleaned up.

          Show
          githubbot ASF GitHub Bot added a comment - Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2477#discussion_r80887299 — Diff: flink-java/src/test/java/org/apache/flink/api/java/io/CsvOutputFormatTest.java — @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.api.java.io; + +import org.apache.commons.io.IOUtils; +import org.apache.flink.api.common.io.FileOutputFormat; +import org.apache.flink.api.java.tuple.Tuple3; +import org.apache.flink.core.fs.FSDataInputStream; +import org.apache.flink.core.fs.FileSystem; +import org.apache.flink.core.fs.Path; +import org.junit.Assert; +import org.junit.Test; + +import java.nio.charset.StandardCharsets; + +public class CsvOutputFormatTest { + + private static final Path PATH = new Path("csv_output_test_file.csv"); + + @Test + public void testNullAllow() throws Exception { + CsvOutputFormat<Tuple3<String, String, Integer>> csvOutputFormat = new CsvOutputFormat<Tuple3<String, String, Integer>>(PATH); + csvOutputFormat.setWriteMode(FileSystem.WriteMode.OVERWRITE); + csvOutputFormat.setOutputDirectoryMode(FileOutputFormat.OutputDirectoryMode.PARONLY); + csvOutputFormat.setAllowNullValues(true); + csvOutputFormat.open(0, 1); + csvOutputFormat.writeRecord(new Tuple3<String, String, Integer>("One", null, 8)); + csvOutputFormat.close(); + final FileSystem fs = PATH.getFileSystem(); + Assert.assertTrue(fs.exists(PATH)); + FSDataInputStream inputStream = fs.open(PATH); + String csvContent = IOUtils.toString(inputStream, StandardCharsets.UTF_8); + Assert.assertEquals("One,,8\n", csvContent); + fs.delete(PATH, true); + } + + @Test(expected = RuntimeException.class) + public void testNullDisallowOnDefault() throws Exception { + CsvOutputFormat<Tuple3<String, String, Integer>> csvOutputFormat = new CsvOutputFormat<Tuple3<String, String, Integer>>(PATH); + csvOutputFormat.setWriteMode(FileSystem.WriteMode.OVERWRITE); + csvOutputFormat.setOutputDirectoryMode(FileOutputFormat.OutputDirectoryMode.PARONLY); + csvOutputFormat.open(0, 1); + csvOutputFormat.writeRecord(new Tuple3<String, String, Integer>("One", null, 8)); + csvOutputFormat.close(); — End diff – The temporary file is created within `open()` and will not be cleaned up.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user kirill-morozov-epam commented on a diff in the pull request:

          https://github.com/apache/flink/pull/2477#discussion_r80901404

          — Diff: flink-java/src/test/java/org/apache/flink/api/java/io/CsvOutputFormatTest.java —
          @@ -0,0 +1,63 @@
          +/*
          + * Licensed to the Apache Software Foundation (ASF) under one
          + * or more contributor license agreements. See the NOTICE file
          + * distributed with this work for additional information
          + * regarding copyright ownership. The ASF licenses this file
          + * to you under the Apache License, Version 2.0 (the
          + * "License"); you may not use this file except in compliance
          + * with the License. You may obtain a copy of the License at
          + *
          + * http://www.apache.org/licenses/LICENSE-2.0
          + *
          + * Unless required by applicable law or agreed to in writing, software
          + * distributed under the License is distributed on an "AS IS" BASIS,
          + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
          + * See the License for the specific language governing permissions and
          + * limitations under the License.
          + */
          +
          +package org.apache.flink.api.java.io;
          +
          +import org.apache.commons.io.IOUtils;
          +import org.apache.flink.api.common.io.FileOutputFormat;
          +import org.apache.flink.api.java.tuple.Tuple3;
          +import org.apache.flink.core.fs.FSDataInputStream;
          +import org.apache.flink.core.fs.FileSystem;
          +import org.apache.flink.core.fs.Path;
          +import org.junit.Assert;
          +import org.junit.Test;
          +
          +import java.nio.charset.StandardCharsets;
          +
          +public class CsvOutputFormatTest {
          +
          + private static final Path PATH = new Path("csv_output_test_file.csv");
          +
          + @Test
          + public void testNullAllow() throws Exception

          { + CsvOutputFormat<Tuple3<String, String, Integer>> csvOutputFormat = new CsvOutputFormat<Tuple3<String, String, Integer>>(PATH); + csvOutputFormat.setWriteMode(FileSystem.WriteMode.OVERWRITE); + csvOutputFormat.setOutputDirectoryMode(FileOutputFormat.OutputDirectoryMode.PARONLY); + csvOutputFormat.setAllowNullValues(true); + csvOutputFormat.open(0, 1); + csvOutputFormat.writeRecord(new Tuple3<String, String, Integer>("One", null, 8)); + csvOutputFormat.close(); + final FileSystem fs = PATH.getFileSystem(); + Assert.assertTrue(fs.exists(PATH)); + FSDataInputStream inputStream = fs.open(PATH); + String csvContent = IOUtils.toString(inputStream, StandardCharsets.UTF_8); + Assert.assertEquals("One,,8\n", csvContent); + fs.delete(PATH, true); + }

          +
          + @Test(expected = RuntimeException.class)
          + public void testNullDisallowOnDefault() throws Exception {
          + CsvOutputFormat<Tuple3<String, String, Integer>> csvOutputFormat = new CsvOutputFormat<Tuple3<String, String, Integer>>(PATH);
          + csvOutputFormat.setWriteMode(FileSystem.WriteMode.OVERWRITE);
          + csvOutputFormat.setOutputDirectoryMode(FileOutputFormat.OutputDirectoryMode.PARONLY);
          + csvOutputFormat.open(0, 1);
          + csvOutputFormat.writeRecord(new Tuple3<String, String, Integer>("One", null, 8));
          + csvOutputFormat.close();
          — End diff –

          Fixed in https://github.com/apache/flink/pull/2477/commits/6d06d0e03e12ced8fe11e164488f1102682704d1

          Show
          githubbot ASF GitHub Bot added a comment - Github user kirill-morozov-epam commented on a diff in the pull request: https://github.com/apache/flink/pull/2477#discussion_r80901404 — Diff: flink-java/src/test/java/org/apache/flink/api/java/io/CsvOutputFormatTest.java — @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.api.java.io; + +import org.apache.commons.io.IOUtils; +import org.apache.flink.api.common.io.FileOutputFormat; +import org.apache.flink.api.java.tuple.Tuple3; +import org.apache.flink.core.fs.FSDataInputStream; +import org.apache.flink.core.fs.FileSystem; +import org.apache.flink.core.fs.Path; +import org.junit.Assert; +import org.junit.Test; + +import java.nio.charset.StandardCharsets; + +public class CsvOutputFormatTest { + + private static final Path PATH = new Path("csv_output_test_file.csv"); + + @Test + public void testNullAllow() throws Exception { + CsvOutputFormat<Tuple3<String, String, Integer>> csvOutputFormat = new CsvOutputFormat<Tuple3<String, String, Integer>>(PATH); + csvOutputFormat.setWriteMode(FileSystem.WriteMode.OVERWRITE); + csvOutputFormat.setOutputDirectoryMode(FileOutputFormat.OutputDirectoryMode.PARONLY); + csvOutputFormat.setAllowNullValues(true); + csvOutputFormat.open(0, 1); + csvOutputFormat.writeRecord(new Tuple3<String, String, Integer>("One", null, 8)); + csvOutputFormat.close(); + final FileSystem fs = PATH.getFileSystem(); + Assert.assertTrue(fs.exists(PATH)); + FSDataInputStream inputStream = fs.open(PATH); + String csvContent = IOUtils.toString(inputStream, StandardCharsets.UTF_8); + Assert.assertEquals("One,,8\n", csvContent); + fs.delete(PATH, true); + } + + @Test(expected = RuntimeException.class) + public void testNullDisallowOnDefault() throws Exception { + CsvOutputFormat<Tuple3<String, String, Integer>> csvOutputFormat = new CsvOutputFormat<Tuple3<String, String, Integer>>(PATH); + csvOutputFormat.setWriteMode(FileSystem.WriteMode.OVERWRITE); + csvOutputFormat.setOutputDirectoryMode(FileOutputFormat.OutputDirectoryMode.PARONLY); + csvOutputFormat.open(0, 1); + csvOutputFormat.writeRecord(new Tuple3<String, String, Integer>("One", null, 8)); + csvOutputFormat.close(); — End diff – Fixed in https://github.com/apache/flink/pull/2477/commits/6d06d0e03e12ced8fe11e164488f1102682704d1
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user fhueske commented on a diff in the pull request:

          https://github.com/apache/flink/pull/2477#discussion_r82594396

          — Diff: flink-java/src/test/java/org/apache/flink/api/java/io/CsvOutputFormatTest.java —
          @@ -0,0 +1,72 @@
          +/*
          + * Licensed to the Apache Software Foundation (ASF) under one
          + * or more contributor license agreements. See the NOTICE file
          + * distributed with this work for additional information
          + * regarding copyright ownership. The ASF licenses this file
          + * to you under the Apache License, Version 2.0 (the
          + * "License"); you may not use this file except in compliance
          + * with the License. You may obtain a copy of the License at
          + *
          + * http://www.apache.org/licenses/LICENSE-2.0
          + *
          + * Unless required by applicable law or agreed to in writing, software
          + * distributed under the License is distributed on an "AS IS" BASIS,
          + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
          + * See the License for the specific language governing permissions and
          + * limitations under the License.
          + */
          +
          +package org.apache.flink.api.java.io;
          +
          +import org.apache.commons.io.IOUtils;
          +import org.apache.flink.api.common.io.FileOutputFormat;
          +import org.apache.flink.api.java.tuple.Tuple3;
          +import org.apache.flink.core.fs.FSDataInputStream;
          +import org.apache.flink.core.fs.FileSystem;
          +import org.apache.flink.core.fs.Path;
          +import org.junit.After;
          +import org.junit.Assert;
          +import org.junit.Test;
          +
          +import java.io.IOException;
          +import java.nio.charset.StandardCharsets;
          +
          +public class CsvOutputFormatTest {
          +
          + private static final Path PATH = new Path("csv_output_test_file.csv");
          — End diff –

          Please use `File.createTempFile()` to create a file in the default temp space.

          Show
          githubbot ASF GitHub Bot added a comment - Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/2477#discussion_r82594396 — Diff: flink-java/src/test/java/org/apache/flink/api/java/io/CsvOutputFormatTest.java — @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.api.java.io; + +import org.apache.commons.io.IOUtils; +import org.apache.flink.api.common.io.FileOutputFormat; +import org.apache.flink.api.java.tuple.Tuple3; +import org.apache.flink.core.fs.FSDataInputStream; +import org.apache.flink.core.fs.FileSystem; +import org.apache.flink.core.fs.Path; +import org.junit.After; +import org.junit.Assert; +import org.junit.Test; + +import java.io.IOException; +import java.nio.charset.StandardCharsets; + +public class CsvOutputFormatTest { + + private static final Path PATH = new Path("csv_output_test_file.csv"); — End diff – Please use `File.createTempFile()` to create a file in the default temp space.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user kirill-morozov-epam commented on a diff in the pull request:

          https://github.com/apache/flink/pull/2477#discussion_r82622593

          — Diff: flink-java/src/test/java/org/apache/flink/api/java/io/CsvOutputFormatTest.java —
          @@ -0,0 +1,72 @@
          +/*
          + * Licensed to the Apache Software Foundation (ASF) under one
          + * or more contributor license agreements. See the NOTICE file
          + * distributed with this work for additional information
          + * regarding copyright ownership. The ASF licenses this file
          + * to you under the Apache License, Version 2.0 (the
          + * "License"); you may not use this file except in compliance
          + * with the License. You may obtain a copy of the License at
          + *
          + * http://www.apache.org/licenses/LICENSE-2.0
          + *
          + * Unless required by applicable law or agreed to in writing, software
          + * distributed under the License is distributed on an "AS IS" BASIS,
          + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
          + * See the License for the specific language governing permissions and
          + * limitations under the License.
          + */
          +
          +package org.apache.flink.api.java.io;
          +
          +import org.apache.commons.io.IOUtils;
          +import org.apache.flink.api.common.io.FileOutputFormat;
          +import org.apache.flink.api.java.tuple.Tuple3;
          +import org.apache.flink.core.fs.FSDataInputStream;
          +import org.apache.flink.core.fs.FileSystem;
          +import org.apache.flink.core.fs.Path;
          +import org.junit.After;
          +import org.junit.Assert;
          +import org.junit.Test;
          +
          +import java.io.IOException;
          +import java.nio.charset.StandardCharsets;
          +
          +public class CsvOutputFormatTest {
          +
          + private static final Path PATH = new Path("csv_output_test_file.csv");
          — End diff –

          Fixed in https://github.com/apache/flink/pull/2477/commits/e789411651ab7a932acf15662977a13ae2833b57

          Show
          githubbot ASF GitHub Bot added a comment - Github user kirill-morozov-epam commented on a diff in the pull request: https://github.com/apache/flink/pull/2477#discussion_r82622593 — Diff: flink-java/src/test/java/org/apache/flink/api/java/io/CsvOutputFormatTest.java — @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.api.java.io; + +import org.apache.commons.io.IOUtils; +import org.apache.flink.api.common.io.FileOutputFormat; +import org.apache.flink.api.java.tuple.Tuple3; +import org.apache.flink.core.fs.FSDataInputStream; +import org.apache.flink.core.fs.FileSystem; +import org.apache.flink.core.fs.Path; +import org.junit.After; +import org.junit.Assert; +import org.junit.Test; + +import java.io.IOException; +import java.nio.charset.StandardCharsets; + +public class CsvOutputFormatTest { + + private static final Path PATH = new Path("csv_output_test_file.csv"); — End diff – Fixed in https://github.com/apache/flink/pull/2477/commits/e789411651ab7a932acf15662977a13ae2833b57
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user fhueske commented on the issue:

          https://github.com/apache/flink/pull/2477

          Thanks for the update @kirill-morozov-epam!
          Merging

          Show
          githubbot ASF GitHub Bot added a comment - Github user fhueske commented on the issue: https://github.com/apache/flink/pull/2477 Thanks for the update @kirill-morozov-epam! Merging
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/2477

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2477
          Hide
          fhueske Fabian Hueske added a comment -

          Fixed for 1.1.4 with 9591d50fc6f3b2d7fab3af7aeee29e04d11b7811
          Fixed for 1.2.0 with a85d8e57a3501e39284e24221b50c6222e85c06c

          Show
          fhueske Fabian Hueske added a comment - Fixed for 1.1.4 with 9591d50fc6f3b2d7fab3af7aeee29e04d11b7811 Fixed for 1.2.0 with a85d8e57a3501e39284e24221b50c6222e85c06c

            People

            • Assignee:
              kirill-morozov-epam Kirill Morozov
              Reporter:
              mwong Michael Wong
            • Votes:
              1 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development